Realm Rank is wrong? about uthgard-herald

[burfo]

Not the first time I've heard somebody say that. I suspect the splits are wrong within the API.

[andir]

@thekroko The current code has a classic off-by-one issue which can be fixed by handling the zero RP case dfiferently and adding 10 to each n-i'th value:

func getRRForRP(rp int32) int {                                                                           
        if rp > 0 {                                                                                       
                n := len(rpForLevel)                                                                      
                for i := range rpForLevel {                                                               
                        idx := n - i - 1                                                                  
                        if rpForLevel[idx] <= rp {                                                        
                                return (n - i) + 10                                                       
                        }                                                                                 
                }                                                                                         
        }                                                                                                 
        return 10                                                                                         
}

(based of http://pastebin.com/7cAwJUUQ)

You should probably add some tests to your test suites. The following cases turned out to be useful:

                                                                                                          
func main() {                                                                                             
        type Test struct {                                                                                
                rp   int32                                                                                
                rank int                                                                                  
        }                                                                                                 
                                                                                                          
        tests := []Test{                                                                                  
                Test{0, 10},                                                                              
                Test{25, 12},                                                                             
                Test{750, 15},                                                                            
                Test{73683, 31},                                                                          
                Test{1668226, 69},                                                                        
                Test{66181501, 130},                                                                      
        }                                                                                                 
                                                                                                          
        for _, test := range tests {                                                                      
                rr := getRRForRP(test.rp)                                                                 
                if rr != test.rank {                                                                      
                        fmt.Printf("%v shoule be %v (%v)\n", rr, test.rank, test.rp)
                } else {              
                        fmt.Printf("    ✓ %v is %v (%v)\n", rr, test.rank, test.rp)                       
                }                                                                                         
        }                                                                                                 
                                                                                                          
}

[thekroko]

Fixed with next push. Thank you! :)