thekroko / uthgard-herald

Help us build a herald.

uthgard-herald

Docker Status

Community implemented Herald for the Uthgard server. Git repository is automatically deployed to https://herald.uthgard.org once per hour.

uthgard-herald's Issues

you slow down multiple request now ?!?!

hey, i noticed that you configured your api to response to "high frequency" request with a delay of 30s-60s.

I was trying to tell you that somebody will do that. (this time i was - about 14 request per min) to build my database with the uthgard data.

Good for you that you have now a way to block this kind of "get-all-data", but i saw it is only ip based, hopefully it is not ip4 only .... every normal internet connection with ipv6 hat 32k ipv6 addresses ;) or even a tor proxy would bypass the limitation ;)

I will stop here, you dont want the features i offered, i respect this even if you has not ask the comunity if they want this. So have fun, see you ingame maybe ....

favicon missing

Currently the favicon is still the default angular(2) icon. Do we have anything more fitting?

Add build status

https://github.com/dwyl/learn-travis

Would be nice if someone can integrate it

Realm war map

We should add a realm war map. Probably as or on the start page.

armsperson/@prsauer (on IRC) linked the two pages he made:

1. http://uthgard.riftmetric.com/realmwar.html
2. http://uthgard.riftmetric.com/realmwar2.html

I think (the 2nd, realmwar2.html) is pretty neat and would do well on index/home page.

API not UTF-8

Never mind, all reponses are UTF-8, i only forget to decode it.

Player API reporting incorrect character level.

Since the 02/14 API code push, anyone who levels up is reported as one level lower than they actually are. This is the same symptom as the realm rank bug that was corrected.

Example: https://uthgard.org/herald/api/player/Orito
02/14, after the API code push, I leveled up to 40. Last update is clearly post that day/time.

From what I can tell, characters that have not leveled up since the API code push are reported accurately.
Example: https://uthgard.org/herald/api/player/Origami
This character hasn't been played for a week or so, and is reported accurately.

Tests are broken

https://travis-ci.org/thekroko/uthgard-herald

Can someone take a look?

Realm Rank is wrong?

Had some people in IRC reporting their RR shown on the api was incorrect

He's shown as 3L1 in game but 3L0 on api.

{
"Name": "Ramo",
"Guild": "Buds",
"Race": "Avalonian",
"Class": "Paladin",
"Xp": 170000000000,
"Rp": 73683,
"Level": 49,
"RealmRank": 30,
"XpPercentOfLevel": 0.93884605,
"RpPercentOfLevel": 0.17532879,
"LastUpdated": 1487117107
}

License of the project

We should probably decide on a license for this work. I think (A)GPL works quiet well for these kind of things.

Any thoughts?

Make Docker deployable

Make sure everything can be deployed via docker ("docker run .." should produce a local webserver listening on some random port that displays that page).

Add a default index or ranking view

have a default /index or /ranking view, and make sure you can navigate between it and the existing /char/Foo subpages (i.e. add breadcrumbs/links/navbar)

Launch?

Has this been 'officially' launched yet? If not what are the blocks to its being launched? It seems to be quite close to a basically usable point, but no progress has been made in quite some time. I could probably spare some time to work on it but I don't want to waste time on useless features.

List all players

How to request a list of all players (to create a top10 rps player etc.)

Guild endpoint doesn't work

This is causing a delay in switching to using the actual data, following endpoints not working:

https://uthgard.org/herald/api/guild/critical - not found
https://uthgard.org/herald/api/guild/Critical - not found
https://uthgard.org/herald/api/guild/critical/ - 404
https://uthgard.org/herald/api/guild/Critical/ - 404

More player data

How to put more data of the player into api answer e.g.

• alb player kills
• mid player kills
• hib player kills
• alb death blows
• mid death blows
• hib death blows
• alb solo kills
• mid solo kills
• hib solo kills
• deaths
• dragon kills
• legion kills
• crafting profession
• crafting skilllevel
• housing infomation
• gender

Player search algorithm needs improvement

It looks like
https://uthgard.org/herald/api/search/player/Arms
is using simple prefix matches to return results.

Would be nice to have something a little smarter -- I know @thekroko had suggested a trie and I think that would work pretty well. I think etas in irc had some other suggestion.

Make a page for guild data

Would be nice to be able to see guild data, guild members etc. on a page. I'll start working on this for now, until I hear otherwise

Add a search for character

add a search for char --> go to /character/Foo

Lacking overview of implemented API endpoints

We need an overview of all currently implemented API endpoints

Guild emblem image endpoint

Need this for displaying guild info

suggest:
http://images.uthgard.org/guilds/{guild}.jpg

to mirror the player images api

Add Access-Control-Origin Header to api server

Browsers check the Allow-Control-Origin-Header with an OPTIONS request before performing XHR.

In our case we'd the header to state herald.uthgard.org.

For nginx the config line would be:

add_header Access-Control-Allow-Origin herald.uthgard.org; 

For varnish (which seems to be at least the frontend server of uthgard.org):

set resp.http.Access-Control-Allow-Origin = "herald.uthgard.org";

If you want to be more permissive (e.g. allowing 3rd party hosted heralds) use * instead of herald.uthgard.org

Use the old code?

Looking at the old code, it doesn't really work, at all. I say that as someone who wrote a fair amount of it. Given that it's currently virtually useless, would we be better to start this again from scratch?

Is there a reason to be using angular? Since working on this I've used a lot more Vue and React, I'd say they're quite a lot better, and easier to get going with.

Realm 7 -- custom content????

I demand more information about this Realm 7, I wish to make a character there

https://uthgard.org/herald/api/player/Babypony

{
Name: "Babypony",
Guild: "",
Race: "Troll",
Class: "Berserker",
Realm: "7",
Xp: 8459615088,
Rp: 1,
Level: 39,
RealmRank: 11,
XpPercentOfLevel: 0.5520564,
RpPercentOfLevel: 0.04,
LastUpdated: 1487640474
}

Update URL to guild emblem image

Once we fix #36, need to update our existing URL references.

I believe character-profile.component.html
is the only place.

Update README.md with dependencies

Setting up environment for docker image and have ran into issues, so I suggest updating README.md to reflect requirements:

install npm
install node (https://nodejs.org/en/download/)
npm install angular
npm install -g angular-cli (unsure of what -g flag is for, but angular-cli states this command: https://github.com/angular/angular-cli#installation)

Any addition info, like required node.js version to run this app, etc. would be great.

Fix docker build

https://hub.docker.com/r/uthgard/herald/builds/

Looks like something is wrong with the code. Image doesn't build.