themonster2015 / awesome-books

Hello 👋, I am ✨Yen✨

Remote Full-stack web developer ready for an awesome adventure ahead

ABOUT ME

const themonster2015 = {
  lookingFor: "Front-end developer" || "Full-stack web developer",
  pronouns: ["she", "her"],
  code: [JavaScript, React, Redux, Ruby on Rails,CSS, SQL, HTML/CSS, Semantic UI, Bootstrap],
  askMeAbout: [Vietnam, New Age topics, web development],
  challenge: "I am improving my resilience level",
  funFacts: ['I have 8+ years of remote work experience as a freelance writer and also did some digital marketing on the side', 
  'I can't live without good coffee']
}

Connect with me:

Languages and Tools:

awesome-books's Issues

Suggested Changes

Great Job, Yen:+1:

However, we have some suggestions for you.

No 1.

We suggest you be consistent in your DOM API methods. You can stick to either:point_down:

document.getElementById()

OR:point_down:

document.querySelector()

Your Code

awesome-books/app.js

Lines 1 to 4 in 30a6a3b

	const title = document.getElementById('title');
	const author = document.getElementById('author');
	const addBtn = document.getElementById('addBtn');
	const booksList = document.getElementById('booksList');

awesome-books/app.js

Line 64 in 30a6a3b

this.delBtns = document.querySelectorAll('.delete');

We advise you to use only class attributes in your HTML files except where it is unavoidable to use id attribute. With this, you can stick to using 'querySelector' DOM API method in your js file.

Read this:point_down:

reasons not to use ids

No 2.

Please add a live link to the merged version (the main branch)

Happy Coding:tada:

Update your live link

• Space your HTML elements out, you could use margins for that, the h1, the display table, and input fields need some spacing on the top and bottom
• Align your date and time with the navigation bar.