Clash of directory separators ahead about framework

[jlambe]

It was defined like so before but didn't work on windows computer for weird reasons ?!
I would need more users report to see if we have to change that line.

[franz-josef-kaiser]

I am on a windows computer :)

[jlambe]

Me too :) Does the framework run when you activate it ? I've tested several times on my windows7 and it keeps crashing when the DIRECTORY_SEPARATOR constant is defined. Is the constant from a PHP extension or is it in the core ?! Maybe my php config is not right.

[franz-josef-kaiser]

It's a PHP constant...

[jlambe]

Could you test on your local machine the framework by replacing /with the DIRECTORY_SEPARATOR and report what's happening? I need to fix this for 1.0, thx ;)

[eric-holmes]

One note here is that you should only be using DIRECTORY_SEPARATOR for php paths, not JS/CSS/images/etc. Just in case you are using it for any of those! ;)

[jlambe]

Hmmm that's probably the issue then. Yes the DIRECTORY_SEPARATOR was/is used for both paths and URLs. I haven't found in the docs any elements related to that.

[franz-josef-kaiser]

Yep, @ewholmes is right on that one. Btw, don't try PATH_SEPARATOR - I saw it was referenced in the same php.net docs page. That's just for separating/appending include paths.

[jlambe]

So the solution would be to keep DS as DIRECTORY_SEPARATOR and then define a second constant for urls with the value /. So everything keeps working whatever systems it is used on. Thanks for pointing that out!

[franz-josef-kaiser]

yes. But you can simply write / instead of using a second constant. That 2nd constant anyway wouldn't be anything else than what people use as default: /. I'd just drop it for clarity.

[eric-holmes]

Yeah I would agree with @franz-josef-kaiser - it's overkill - "folder" . PS . "script.js" is less readable than "folder/script.js"

[jlambe]

I'll fix all system paths with the DIRECTORY_SEPARATOR and make sure URLs use the simple / entity.
Fix for release 1.0