thepansmith / monifactory

A Modern Remaster of Nomifactory

Gaming

monifactory's Issues

[Bug]: Server crashes when opening any Gregtech machine because LDLib isn't present

Issue Summary

See this issue for details. I had this exact crash. Installing LDLib in client and server resolved the issue.

Reproduction steps

1. Try to open any Gregtech machine while connected to a server.
2. Server instantly crashes.

Relevant log output

See the linked issue if you want the log output.

Adding chipped

• Add Chipped, Chipped Chisel Integration, and Chipped Express
• Hide the chipped crafting stations and sophisticated storage upgrades (irreverent with chipped express, which lets you do them all in the stonecutter)
• Hide the chipped crafting station EMI recipe tabs.

[Bug]: Sky changes colors

Issue Summary

The sky appears to be switching from a darkish look to the normal MC look when I'm sprinting around my world:
https://imgur.com/a/xMHmMbx
I'm not running any commands, it just happens. And its not when switching biomes, I've seen the sky spazz out before, while running in a Plains.

Reproduction steps

Load a default world (I have LostCities mod disabled because I couldn't turn them off manually)
Sprint around. It didn't happen for me until 10 minutes in.

Relevant log output

No response

[Proposal] Remove the last things that depend on Fabric

Fabric compat mods are crashaholics, and the last couple mods that require it can easily be replaced or done without.

[Bug]: Loot chests spawn with Ender IO Dark Steel

Issue Summary

Loot chests in the cities spawn with ender IO dark steel, but it's unusable since Gregtech dark steel is the usable one. Either remove from loot tables, add a conversion recipe, or replace the loot in the chests.

Reproduction steps

1. Loot a city chest with dark steel
2. Obtain a useless ingot

Relevant log output

No response

[Bug]: Producing Budding Certus Quartz is currently impossible

Issue Summary

Budding certus quartz requires an in-world transformation with charged certus quartz and a certus quartz block. The certus quartz block is dictionary filtering correctly but the charged certus quartz is not, and ae2 charged certus quartz is unobtainable since the charger produces Gregtech certus quartz.

Reproduction steps

1. Try to craft budding certus quartz
2. It is not craftable without using cheats to swap the charged certus quartz from Gregtech to AE2

Relevant log output

No response

Fix Actions

Lostcities loot table work

• First and foremost, the issue of it not consistently generating loot in chests needs to be fixed, may be an issue with the mod itself.
• Past that, I'm thinking the loottable could do with a couple of additions to better round it out. ULV Covers, spider eyes (for HNN crafting), silk touch books and such could be useful additions

[Proposal] Add quest for Effortless Building range upgrades

Effortless Building has reach and power upgrades now (can't tell if this was the case in Nomi), perhaps an addition to the already existing EB quest or a new one entirely might be useful to players (unless of course, you want to remove these upgrades entirely)

[Question] Is the massive disparity between the NFu creative tank provider and Moni creative tank fabricator deliberate?

I could fix it in a minute on my current cleanup PR #126 but I want to make sure I'm not doing something stupid if the change was deliberate.

[Bug]: effortlessbuilding-3.8 crashes severs on startup

Issue Summary

Known issue with 3.8. 3.7 worked and was in 0.1.0 update in 0.1.1

Reproduction steps

start dedicated server on 0.1.1

Relevant log output

https://mclo.gs/1pkBnjC

[Feature]: Rubber Drawers

Suggestion

Rubber drawers does not exist for Functional Storage on Modern, either make a recipe that uses rubber planks and gives an oak drawer or wait until Pansmith eventually makes Rubber Drawers Modern

Fix Mini Utilities flight issue or replace it's items.

OneLemonyBoi/MiniUtilities#159

Rebranding Work

• Text, Code
• Logos, Assets

Implement Simulation Supercomputer

Works like the NFu one

NFM issues that are still on Moni

• Add Ender Lilies to the Insolator (#81) Mini utilities was removed
• Add facade crafting recipe to EMI
• Cleaning impure dusts in a cauldron doesn't work (this could be a GTM bug to be fair)
• Replace JEI with EMI in quests (#68)
• Hypochlorous acid quest (Microverse chapter) uses the same description as the ammonia quest (WIP #28)
• A lot of mid game chapter liquid quests requires liquid instead of bucket of liquid, making them incompletable
• Pulsating Polymer Clay texture uses prediction matrix texture from HNN (#1)

Functional Storage Work

• Rexture, Rename Netherite Upgrade
• Give Creative Storage Component a texture

KubeJS multiblocks dont have minimum casings

Suggestion

All the custom multiblocks don't have a minimum casing requirement so you can use buses and hatches instead of casings.

[Feature]: Remove Visual Workbench

Suggestion

This mod turns the regular crafting table into a crafting table with storage. When playing with friends this causes each other to mess up each others recipes. For this functionality the crafting station can be used when desired.

[Feature]: Superfabricator to process pristine predictions from the Supercomputer

Suggestion

At UHV (tier when you achieve supercomputer), you will be running it at 1 tick per recipe if you use a UHV energy hatch.
Currently, loot fabricators are simply too slow to keep up with how fast you're going to be generating pristines (one stack of PPM outputs ~48 pristines in ~3.4 seconds)
So a Superfabricator multiblock of sorts to process them at the same speed would be really useful I think

[Bug]: Glass Tubes Recipe is using the wrong tag

Issue Summary

Attempting to craft glass tubes gives this:

The correct tag is forge:glass_panes

Reproduction steps

1. Try to craft glass tube.
2. You can't craft it in a crafting table.

Relevant log output

No response

[Bug]: Effortless building Elastic Hand not actually consumed after use

Issue Summary

After using the Elastic hand, going into inventory and clicking the slot it was in will pick it up again when it should be consumed, it may then be re-inserted and used again in this way

Reproduction steps

Obtain an Elastic hand then right click while holding it to consume it and increase the relevant stat by 1 level. Go into your inventory and click the slot where the hand was, and it will reappear. Place back into inventory and repeat

Relevant log output

No response

Nuclearcraft Sulfuric acid is useless

Issue Summary

No recipe, less uses than gregtech's, and as Aubrey said on the discord:

Also wondering what other liquids from NC are duplicates. I haven't checked much
EDIT: Liquid Glowstone? 3 different ones?

Reproduction steps

1. Look at a recipe using sulfuric acid
2. Realize that, as a player, there's only one real sulfuric acid

Relevant log output

No response

Retexturing

At a point where I think we can start doing a little work on assets.

Obviously not intended to be all done by one person (but I'm not stopping ya if you really want to), just make a comment here before you start work to make sure people aren't working on the same task. For those that need a refresher on jappa style, take a look at this.

Microminer stuff

• Gemstone Sensor
• Universal navigator
• Warp engine
• Quantum Flux
• Basic Mining Laser
• Reinforced Mining Laser
• Supercharged Laser Array
• Microminer Guidance System
• Advanced MGS
• QFEHP (T9MM plates)
• Microminers

The microminers themselves will be done after all of the above is done, to make sure that the MMs are visually consistent with the things used to craft them.

Blocks

• Sophisticated Storage teired barrels
• Dust block

Widgets

• Wood
• Stone
• Alloy
• Ender

Items

• KubeJS thermal dusts (Cryotheum, Aerotheum, etc)
• Sophisticated Storage Barrel upgrades and Stack upgrades
• KubeJS clathrates
• Solidified Elements
• Stablized Elements (maybe different texture than solidified to reflect the recipe?)
• Dense Hydrogen, Ultra Dense Hydrogen
• Dilithum crystal
• Unprepared Space Suit
• Misc space suit stuff
• Pulsating dust and Mesh
• Ender, Endest Star
• Radium salt, Moon dust, Grains of innocence (prob just tint the base GTm dust texture lol)
• Smores
• Nomicoins
• Nether Star parts
• Eternal and Exotic Catalyst
• HoTU
• Creative Storage Component (I guess just make a pulsating storage upgrade or something)
• Mote of Omnium
• Ultimate Material

The following items do not have textures in NFm currently, so refer to Nomi CEu

• Control Unit, empty and filled
• Glowstone Elevation Unit (can prob just recolor the above)

New Posttank Items

• Tier 11, 12 Microminer
• Corrupted Universe Data
• Scrap, ruined capacitor, ruined sensor, ruined emitter
• Holmium Oxide Glass Dust, Holmium Compound, Magnetic Capacitor Dust
• Complex SMDs
• Matter, Dimensional Processing Unit
• Creative Datas
• Omnic Pulsar Compound
• Shattered Star data
• Singularity containment unit, contained singularity
• QSoCs

DE Removal Related Items

• Deep Dark Data, Lair of the warden
• The cores
• Compound, Fusion Casings
• Warden Heart
• Warden Tendril
• Abyss shard
• Solars
• Conduits
• DE reactor stuff (feel free to rename/redesign)
• Energy Cores (can prob just use the regular cores as a base)
• Particle Generator (could do with a rename as well)
• HI casings

HM stuff

• magnetron
• Microminers 4.5 and 8.5 (dont make them look silly like the OG ones lol)
• Pristine Microverse Matters
• Dense Magma
• Omnic Data

[Bug]: Tooltip from GregTech machines overlaps with EMI UI

Issue Summary

Reproduction steps

Open a GregTech Machine and hover the mouse on the i at the top right of the interface

Relevant log output

No response

[Feature]: Remove MiniUtilities and replace with Better Angel Ring

Suggestion

There are exactly 2 items used from Mini Utilities. Experience Pearl, and Angel Ring. The former is easily replaced with KubeJS and the latter with Better Angel Ring mod.

[Bug]: AE2 pattern encoding misscounts

Issue Summary

Whenever I try to encode circuit pattern:

• Fluid does not transfer (idk if it's supposed to or not)
• Some items are in wrong counts, from what I see its because of "#gtceu:resistors" instead of exact type of resistor

Reproduction steps

1. Open recipe of circuit (tried with MV and HV circuit)
2. Fill the recipe into ae2 pattern encoder
3. Cry and fix the recipe manually

Relevant log output

No response

Remove/Replace Avaritia Fabric, was removed from curseforge

• Remove Avaritia
• Replace Items
• Replace Textures

[Bug]: Circuit assembler recipes keep not working (Singleplayer, idk about multi)

Issue Summary

Sometimes when crafting circuits using circuit assembler the recipe does not work, this can sometimes be fixed by reloading the game or save. This is likely cause by tags, as the recipe uses "#forge:tin"

Reproduction steps

1. Try to craft LV circuit with molten tin
2. Circuit assembler does not work (it got power)

Relevant log output

No response

[Bug]: Chipped Express doesn't work for blocks from Chisel Chipped Integration

Issue Summary

Items from Chisel Chipped Integration do not appear to be working correctly with Chipped Express, and only the base variants of those blocks are currently craftable as a result.

Reproduction steps

1. Try to craft "Large Tiles" laboratory block
2. You can't craft it.

Relevant log output

No response

[Discussion] Mods to remove/keep

There are a few mods that could be removed to save on performance in Moni that I found

Definitely remove:

• Artan'sProjectCoreMod: Probably a leftover from some removed mod
• Lemon Lib: Used for MiniUtilities, which was removed
• Stack Refill: Functionality already provided by Inventory Tweaks Refoxed
• CIT Resewn: Wait why is this here anyway? Isn't this a Fabric mod?

Mods that could be removed:

• AE2 QoL Recipes: All this mod adds is a bunch of recipes, the mod itself is empty otherwise. Could be implemented via KJS instead
• Leaky: Its unlikely that players will ever build vanilla farms when HNN exists, so its usefulness is incredibly small
• Energy Meter: To be honest, this one can be kept for all that I care, but its a question of if it really adds anything to the pack. Players can add it themselves if they really want to measure their power rates
• 3D Skin Layers: Again, does it really add anything to the pack? Clientside so players who want it can add it themselves
• Showcase Item: Same as above
• Water condenser: Not sure about this one, might be worth looking into if KJS can make a block that outputs water. If so, that would remove the need for this mod entirely
• Ender Crop: With HNN, why is this really requred? Its going to be obsolete so fast and that's assuming the player even obtains it before achieving sim chambers
• Model Gap Fix: Also a client side mod that really adds nothing to the pack. However, I am in favor of keeping this because why is this not in base MC anyway?
• Visual Workbench: Client side, doesn't really add anything
• WaterFrames: Ok yeah, frames are funny for multiplayer. But the mod is like 54MB so is it really worth it? Keep in mind that not many people are going to use it in singleplayer or even in multiplayer for that matter except to goof off
• Wireless Chargers: Not sure how much use this mod will get, Nomi doesn't have any blocks with its functionality either afaik
• Overloaded Armor Bar: What use is this going to have in Moni, a peaceful modpack lol. Plus I don't think there's any actual armors that players will use that needs an overloaded armor bar
• No Recipe Book Reborn: Is the recipe book really that annoying? It only takes up a few pixels on the screen. Plus there will be players (myself included) who use it, even if just to quickcraft from materials available in the inventory
• No Auto Jump: There's going to be SOME people out there who want auto jump. Just ship the pack with it disabled by default in options.txt instead of adding another mod; this lets the players who want it enable it as well

Performance mods:

• Saturn: Testing it myself shows that Saturn actually increases memory usage by about 400MB. It is to be noted however, that CPU usage is reduced by about ~2-3% however. Spark profiles from testing below

Without Saturn: https://spark.lucko.me/sEjlply7b3
With Saturn: https://spark.lucko.me/9KgkF44frf

• FTB Quests Optimizer: Not required on client, could just pack it with server files instead
• Smooth Boot: Testing required
• Smooth chunk save: Testing required
• Redirector: Testing required

This list may be subject to change as I take a closer look at the mod list

Sophisticated Storage EMI cleanup

Hide all uncraftable barrels

[Bug]: Shift-Clicking a recipe into a crafting station simply deletes the excess materials

Issue Summary

when shift-clicking recipes to the crafting station with an attached inventory deletes the excess materials
i.e recipe requires X and in the connected inventory theres 32X's (example ammount), shift-click recipe and now theres only 1X in the crafting grid and the other 31X's is gone

Reproduction steps

1. have a crafting stion connected to an inventory
2. have the ingredients of the recipe in the connected inventory
3. shift-click the recipe from EMI

Relevant log output

No response

[Feature]: Replace Infinity Armor set with an Infinity Tool set, gregtect style

Suggestion

Crafting the best item should require the best tools.
Not to mention, there's just as much potential for nested crafting and material cost as an armor set + sword.

Ultimate Storage Component Recipe Fix

Change the Ultimate Storage Component to use the barrel upgrades instead of the barrels

Thermal Todo

• sync all recipes
• add all the different coils thru kjs

PackagedAuto potential removal?

Is packagedAuto used for anything other than a workaround for larger pattern sizes? Modern AE2 patterns can do 81 in, 27 out by default.

Assuming this is the only reason it was included then there a reason to keep it?

Also AE2 15.1.0 will crash with packagedauto. Needs to be updated to 15.1.1 to fix that.

[Bug]: Combination Crafting pedestal uses Extended Crafting Black Iron instead of GT Black Steel

Issue Summary

Just gotta replace the block in the recipe.

Reproduction steps

Launch game

Relevant log output

No response

Questbook Issues

Missing Dependencies, spelling errors, etc

[Proposal] Add Chipped as a decorative replacement to Chisel

Chipped has a lot of nice building blocks added and with Chisel Chipped Integration replicates most of the blocks Chisel adds.

[Feature Request]: Replace Rechiseled with any other chisel mod

Suggestion

Im just saying this because the mod by itself adds about 1.7GB more to the ram usage which makes the modpack not run on 5gb of ram anymore. even worse my 8gb of ram allocation was maxed out

[Bug]: Smelting Gregtech silver dust produces Nuclearcraft Neotoric silver ingot with no uses

Issue Summary

Instead of receiving GT silver ingot I receive Nuclearcraft silver ingot that cant be used in recipes.

Reproduction steps

Smelt GT silver dust in normal furnace
Makes unusable silver ingot

Relevant log output

No response

[Feature]: Add Lootr

Suggestion

Would be really nice especially since Nomi (and by extension, Moni) is a pretty popular modpack for servers to run

[Proposal] Use Git LFS for binary files

Git LFS offers several advantages over plain Git for managing repositories with binary files. Notably it vastly reduces clone times and repository size.

This ticket is a proposal to switch to Git LFS for handling binary files.

See this GitHub article on how to migrate to Git LFS.

See this GitHub article on why Git LFS is preferably over just throwing binary files into a repository.

Things Worth Considering

• While Git LFS makes working with repositories containing binary and/or large files much easier it does require anyone wanting to work on the repository to have Git LFS installed locally.
• It might be a good idea, if this proposal is adopted, to put information about the use of Git LFS into a readme (once one exists).

[Bug]: Battery Alloy Dust Missing

Issue Summary

Battery Alloy dust is missing the recipe of 4 lead dust 1 antimony dust. This causes an basic alloy smelter to have to be made before you can store power, which is out of order of the quest book.

Reproduction steps

Try and craft battery alloy dust with 4 lead dust and 1 antimony dust.
No recipe for battery alloy dust with lead and antimony.

Relevant log output

No response

Implement Draconic Fusion Reactor

Post tank multiblock, basically works the same as the current draconic fusion multiblock, but parallelizable, and doesn't require the injectors in the recipe

[Proposal]: Add Pipez as an alternative to EIO conduits/GT pipes

Suggestion

Currently EIO conduits are in a pretty unfinished state compared to older versions of the game and do not support item filtering and upgrading. GT pipes support this and are very scalable but they are relatively complicated compared to the simplicity of an item or fluid conduit. Pipez is simple yet effective and isn't as generally buggy as EIO conduits right now. Example:

This is a simple brewery into a Super Tank setup and the fluid conduit is just incapable of sucking the fluids out.

Pipez can actually pull the fluids out properly:

I also set up a basic system to produce vinyl chloride, which makes hydrochloric acid as a byproduct. Pipez destination filters can filter the GT fluids and send them where you want:

Additionally, the transfer rates of items and fluids can be configured to your liking to put the pipes in a spot that feels appropriately balanced when compared to Gregtech pipes.

Known Limitations:
-Energy pipes don't send energy into GT energy converters, and should probably just be disabled as they'd cause balance issues with energy conduit progression anyway.
-The ultimate pipes seem to be a little finicky in this version. I had inconsistencies using the destination tool with them and would suggest that they're just disabled, especially since I think the energy pipes should just be disabled and it wouldn't be easy to remove them from the ultimate pipes.
-Upgrades work for all pipes, so upgrades would have to be balanced around affecting all pipes from the mod (not a big deal if energy pipes are disabled).

Thanks for taking the time to review my proposal.

Implement Research

• Quests
• Recipes

[Bug]: Discord "currently playing" displays Nomi Modern instead of Monifactory

Issue Summary

Reproduction steps

Play Monifactory while being online on Discord

Relevant log output

No response

Recipe Issues

Missing Recipes, etc
Easier to keep them all in a single chain.
If it's GTM related, report it to them.