GithubHelp home page GithubHelp logo

Comments (3)

colinodell avatar colinodell commented on June 19, 2024 2

Thanks for catching this! Looks like that example has been incorrect since we switched to align= in v1.3.0 (when we adopted the GFM spec - see #409). I'll get the docs fixed shortly.

from commonmark.

ptmkenny avatar ptmkenny commented on June 19, 2024

@colinodell Ok, thanks for confirming that the output is as expected!

I discovered this issue by running the W3C validator on my site, which produced the following error for the tables:

From line 339, column 25; to line 340, column 19 in resource file:/example.com/style-guide.html
Error: The "align" attribute on the "th" element is obsolete. Use CSS instead.

I understand that following the GFM spec means that the default behavior can't be changed, but do have any suggestions on how I might override the Tables extension to produce CSS instead of the align attribute for my site?

from commonmark.

colinodell avatar colinodell commented on June 19, 2024

You'd likely need to override TableCellRenderer somehow - either by decorating or replacing it.

Given that align is indeed obsolete, we could add a new configuration option making it easier to switch between the different options. I'll put together a PR in a few minutes with how that might look :)

from commonmark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.