(feature) Support net45 about snapper

[theramis]

Sure, i can send two pr. one with the current fix to support net45 until v2 is ready and another one for the v2 fixes.

That would be awesome!

[theramis]

Changes merged and released in version 1.4.0.

The changes for V2 should be released today/tomorrow in the 2.0.0-beta.

[viceice]

gist

[theramis]

Hey @viceice
I'm currently working on V2 of Snapper which is in this branch https://github.com/theramis/Snapper/tree/v2. There is a nuget package for it as well here https://www.nuget.org/packages/Snapper .

Unfortunately V2 currently doesn't support .net 45 either.

Could you perhaps try and see if you can make the code in v2 work with .net45?

Unfortunately the current version in master will be deprecated in the next month or so.

[viceice]

Sure, i can send two pr. one with the current fix to support net45 until v2 is ready and another one for the v2 fixes.

ok?

[theramis]

@viceice just had a thought.
If you are happy with using the beta version of V2, you could just make the changes for V2 and save yourself some extra work. I'll be releasing the beta version in the next 2 days.

[viceice]

the fix for the current master is ready, see above gist. i only have to fork your repo, push my local commit and open pr 😄

[viceice]

done 🎉

[viceice]

why you don't run all tests with appveyor logger?

[theramis]

done

Yay thanks a lot. Just has one comment. Once that resolved, I'll merge and deploy tomorrow sometime. (Super late in my timezone)

why you don't run all tests with appveyor logger?

Originally only added to the Nunit tests because the nunit runner has some issues. I might add it to all now though to make life easier.

[viceice]

no problem, fixed the issues.

here in germany we have early afternoon 😄