therealchisco / cdmchat Goto Github PK

When simultaneously writing a yet unsent message and receiving a message in the client's terminal, the text of both unsent locally-written message and the received message get scrambled together.

This isn't an issue right now, but it probably eventually will. The variable "File" should definitely be declared as a local variable inside the shell function, because if in any other sourced script a global variable with the name of "File" was declared, its value will be changed. Good practice: always declare variables inside functions as local, then their scope will end when the function terminates, and if they share a name with a global variable, only the local variable will be used inside the function.

-> test program after declaring variable as local and closing this issue ;)

ncat does not seem to be a native shell built in on Mac OS X under this name, it is rather referred to as just nc.
-> Work on UNIX compatibility by choosing appropriate function after finding out OS with uname

Linux sysadmins: Understand ncat's power to avoid accidental security risks
Let me just quote the article:

"And now you see the real danger of using ncat as root. Malicious actors will set up such a shell on a clandestine port that's missed by a port scan and have full root access without authentication."

Let's maybe say, that we are not running the shell as a command from ncat, or that we are not giving ncat sudo rights server side (which we are doing by running it with user "hap"), it is still quite a shitty implementation because we are pretty much opening a port wide open, for anyone willing to inundate the chat_log with whatever they send to this port (since it does not need any authentication to allow the transfer of data). Let's think of migrating this to ssh, or something else. (Another possible solution is to allow only authenticated messages (see digital signature) per ncat to be added to the chatlog, but I think this still makes the service vulnerable to DoS). gg

After exiting application and closing the tmux session and panes when attempting to reconnect
we get the following error
Ncat: bind to :::5214: Address already in use. QUITTING.
Perhaps it's because we are not exiting the ssh session properly