Exclusivity / inclusivity problems about choose

[theryangeary]

readme mistake

You're right, this is a typo on my part.

python-like

Yes, admittedly this is not 100% the way python list slices work. Originally exclusivity was default but I found that over and over as I developed and used choose that my mind would assume inclusivity and I wanted to provide defaults that would be commonly appreciated. I plan on adding the ability to specify exclusivity with an environment variable, which it seems you will appreciate given your alias.

empty results when using -x

Astute observation, you have indeed uncovered a bug.

I am going to open separate issues for each of these items.

[omertuc]

Cool, thanks for the quick response.

Regarding the difference from the Python behavior - I think it would be nice if this was explicitly mentioned in the README. Either the exact difference or just mentioning that it's "mostly like-python".

Regarding the env variable - I'm actually personally against an environment variable for exclusivity. It might cause confusion/surprising behavior since it is usually hidden from view - an explicit, visible flag is essential in this case (my alias is an exception to that idea because I only use it in my personal command line / scripts).

[theryangeary]

I think that the environment variable would effectively achieve the same result as your alias. This would be something that should be set in one's shell rc, NOT in one's profile, so it would apply to a shell but not to your whole environment, so if it were used in a script it wouldn't apply.

That being said, I don't think this tool should be used in scripts (bar trivial ones, maybe), just as you wouldn't use rg over grep or bat over cat in a script.

[omertuc]

I think that the environment variable would effectively achieve the same result as your alias. This would be something that should be set in one's shell rc, NOT in one's profile, so it would apply to a shell but not to your whole environment, so if it were used in a script it wouldn't apply.

Fair enough.

That being said, I don't think this tool should be used in scripts (bar trivial ones, maybe), just as you wouldn't use rg over grep or bat over cat in a script.

For now yes, but when Rust takes over the world and replaces all basic unix tools with their Rust equivalents, you'll regret this decision! /s

[theryangeary]

Perhaps someday my friend. And on that day we will probably determine if we are being invoked from a script or a terminal and ignore env vars accordingly! 🦀