thestuckster / pokemonbotdown Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 34 KB

JavaScript 93.66% Python 6.34%

pokemonbotdown's People

Contributors

Watchers

pokemonbotdown's Issues

Relocate keyDifferences(a,b)

We should move this out somewhere else. Some sort of file for utility functions.
https://github.com/thestuckster/pokemonBotDown/blob/master/client2/pokemonClient.js#L225

Player name assertion will not always be true

Unfortunately, I am finding that this assertion will also fail if the opponent leaves :(
https://github.com/thestuckster/pokemonBotDown/blob/master/client2/pokemonClient.js#L87

It looks like if the opponent leaves args[1] will be undefined.

handleSystemLine assertion will not always be true

This assertion will not always be true:
https://github.com/thestuckster/pokemonBotDown/blob/master/client2/pokemonClient.js#L49

When a user changes their avatar, line will be equal to "Avatar changed to:".

Turn object reform

Right now all of the battle code and interface is going into battle.js.

I'm guessing that eventually it might be very worthwhile to delegate a lot of stuff through a Turn class. Without it, the Battle object is probably going to handle a lot of nasty state about what's going on.

Right now I'm going to continue to put turn logic into Battle.js, because I don't have a good enough understanding of what is sent and needed every turn. (I'm going into this project assuming that anything we write is going to be bad the first time through).

Recommend Projects