thierryabalea / aircall-technical-test-pager Goto Github PK

Hi @flomarin88, @hwd, @kimious,

The Use case paragraph is not clear regarding what is triggering the escalation to the next level. The sentence An Alert iterates from one Level to another if nobody at a given Level handled it lacks precision. I don't know if it is part of the exercise to ask clarifications or if it is involuntary unclear.

For example, it never mentions the acknowledgment delay/timeout to escalate to the next level.

Furthermore, the pair programming paragraph mention an endpoint /alerts/:id/next. It suggests that is not the responsibility of the pager application to escalate to the next level. Maybe you have in mind a timer external to the application that will call this endpoint. If it is the case I will probably recommend to name this endpoint: /alerts/:id/ackTimeout. Even if this endpoint have the responsibility to escalate to the next level if required.

Waiting your clarification, I implemented an acknowledgement timeout/delay of 30 minutes for every level.

A possible improvement will be to allow the targets to declare they can't handle the alert. If all the targets do this, it will escalate to the next level. I did not implemented this case. It is probably too much for the sake of this technical test.