GithubHelp home page GithubHelp logo

rspiro's People

Contributors

alexpaynter avatar florihalbeisen avatar lpiep avatar thlytras avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

rspiro's Issues

Z-scores for NHANES3

Thank you for package. I would very much appreciate the addition of z-score calculations for NHANES3 predictions.

Error when multiple spirometry arguments provided

I tried running this package today and found that the documentation for zscore_GLI didn't quite match the behavior. The documentation for the function states: "If only one spirometry argument is supplied, the function returns a numeric vector. If more are supplied, the function returns a data.frame with the same number of columns."

However, if you pass multiple spirometry measures, you instead get this confusing error.

> zscore_GLI(age=seq(25,40,5), height=c(1.8, 1.9, 1.75, 1.85),
            gender=c(2,1,2,1), FEV1=c(3.5, 4, 3.6, 3.9),  FVC=c(3.5, 4, 3.6, 3.9))
Error in zscore_GLI(age = seq(25, 40, 5), height = c(1.8, 1.9, 1.75, 1.85),  : 
  Spirometry parameter vector(s) and somatometric vectors
         (age, height, gender, ethnicity) do not have the same length.

I was able to loop through each measure to solve my problem, but I thought I'd post this issue since I ran into it. Thanks for putting this package together! I came to it from the GLI site.

FEV1FVC definition in pctptred_GLI help wrong

In the help for pctpred_GLI help it specifies the argument:

FEV1FVC FEV1 / FVC * 100%

but it is actually just FEV1/FVC (range 0-1) that is the required argument, not *100%

presumably the same for FEV075FVC argument but not checked this

Ethnicity: race neutral

Would it be possible to implement rspiro package with the race-neutral set of GLI equations (ethnicity = 0)
Thanks

there should be no default value for sex and ethnicity

Thanks for the nice package. Might I suggest:

  1. Renaming the "gender" input to "birth sex"? "Gender" might be misunderstood as gender identity. What reference value formulas have is sex assigned at birth.
  2. Removing default values for sex and ethnicity. There is no reason to assume, by default, that the patient is a white male. Having a default might prevent users from noticing erroneous input and increase the chance of bias.

Thanks!

A warning message about gender

Hi. thanks for developing this package. I am trying to predict some PFT values and I am getting this message.

Warning message:
You have specified more than two unique values for gender. Please check your data. Returning NA.

even though I have my gender as "1" and "2"

Maher,

'setInternet2' is defunct

R version 3.5.1 (2018-07-02) -- "Feather Spray"
Copyright (C) 2018 The R Foundation for Statistical Computing
Platform: x86_64-w64-mingw32/x64 (64-bit)

I tried to install rspiro package per your instructions and got an error:
Installation failed: 'setInternet2' is defunct.

I It may be related to similar issue elsewhere.

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.