thomasboyt / bipp Goto Github PK

can fix this by not using y= for positioning

this is actually really tricky. it basically needs to happen on every RAF, and if that involves filtering over every note, it could be very expensive:

const missedNotes = this.notes.filter((note) => note.time < elapsed + maxJudgmentWindow);

this.setState({
  notes: this.notes.intersect(missedNotes);
});

also, while the miss can be triggered as soon as the note has exited the last possible judgement window, the note shouldn't be removed from the board until it's offscreen...

tricky part is making both use the same input mechanism, I think... need to look into HotKeys impl and see if it's gonna be fast enough for input (use keyDown instead of keyPress)

this is just because it takes ~180 ms to trigger a Miss, while you could totally hit another note in an 8th/16th note run before the miss occurs

no idea what the solution here is. what do other games do in fast runs when you drop a note? does it trigger a miss on the first note as soon as you hit the second? that probably makes sense...

Blocked by #6.

This really should be next, the faster I can add an easy chart the faster I can feel comfortable letting people loose on the game and the faster I can find out how it performs in the wild

possibly related to https://code.google.com/p/chromium/issues/detail?id=422000

• Keyboard navigation
• Song previews
• ???

Redux DevTools look really useful: https://github.com/gaearon/redux-devtools

I suspect the default monitoring setup will freeze/crash on the TICK event stream, but maybe it can be configured to ignore that?

i.e. if you're on an 8th note and decrease to 4th, you should snap to the previous 4th note

wonder if I could set up assignState in the editor store to maintain copies?

:(

right now data flow triggered by a user action causes immediate re-render. i think it's fine to process immediately instead of sampling the on ticks - we have time between frames - but not to re-render between ticks

looks like CSSPropertyOperations.setValueForStyles is taking a LOOOOOT of CPU resources

Instead of requiring the chart author to pick a song and paste a chart, we can just host & load the MP3s and charts from the same directory that's use to store the final charts/songs.

• Add hash of song locations
• Load song MP3 and chart.txt for each song
• Remove load button

This is pretty weird. I'm not actually 100% sure on it, just going off of what I'm observing (I'm hitting 80-90% of notes early)

would allow avoiding code like this

or this

or this

etc

here's how Stepmania does this: https://github.com/stepmania/stepmania/blob/master/src/NoteTypes.cpp#L97-L104

it tracks notes with a resolution of 1/48, but we don't really need anything more than 32nds, so we can use 1/24:

note  frac   simplified
4th   48/48  24/24
8th   24/48  12/24
12th  16/48  8/24
16th  12/48  6/24
24th  8/48   4/24
32nd  6/48   3/24

i think part of this should also be replacing measure offsets with beat offsets; would be a lot easier to read+debug

theoretically the iframe API's playing/buffering events should allow notes to stay in sync with video playback. I am extremely skeptical of this, but if it's possible, using videos for music is obviously far more pragmatic than hosting a bunch of pseudolegal MP3s

e6c821a