thomaspaulin / akl-hockey Goto Github PK

And hopefully save on quota.

The app is called "MyApp" and uses the Ionic icon as well as the ionic splash screen

This will break the page up visually and make it easier to find a team

The filter button is "FILTER" and an arrow instead of being a funnel line material says it should be.

Until the server supports fetching only matches within a particular date range do that in the frontend.

Remove the show all option entirely and that should fix it.

Go through them all and see how many are still valid (deleting the invalid ones) then created issues for them.

virtual-scroll.js:677 Virtual Scroll: Please provide an "approxItemHeight" input to ensure proper virtual scroll rendering

Matches are filtered within a date range. Allow the user to specify this range as part of the filter settings.

However this may be thrown out if using tabs for weeks.

A URL is required for the APK

Use GitHub pages.

The schedule page is takes a while to load anything and offers no progress indication. Especially when the Heroku dyno was sleeping.

I expected it to animate from the top right where the filter button is but instead it comes from centre left somewhere.

Dismiss matches or perform some other action by swiping them to the side.

Ionic's ItemSlide component.

There are many settings in there that are generic.

When a team has no logo URL and if possible when it's not found

When the start and end dates in the filters change there should be a check to see if the new dates extend out past what has already been downloaded and if they do a new server request should be made to download them.

So that in future whatever deployment will know when there is a new version.

The app is much too tightly coupled at this point.

Make it modal.
Have it be a form with, currently,
Team: [team select here]

Happened when I refreshed after promoting new changes to SNC-API Heroku

[110]/SchedulePage.prototype.presentFilterModal/<@http://localhost:8100/build/main.js:138:17 ViewController.prototype._willUnload@http://localhost:8100/build/vendor.js:23561:31 NavControllerBase.prototype._willUnload@http://localhost:8100/build/vendor.js:56586:13 NavControllerBase.prototype._cleanup@http://localhost:8100/build/vendor.js:56488:21 NavControllerBase.prototype._transitionFinish@http://localhost:8100/build/vendor.js:56387:13 NavControllerBase.prototype._transitionStart/</<@http://localhost:8100/build/vendor.js:56367:20 F</l</t.prototype.invoke@http://localhost:8100/build/polyfills.js:3:14974 onInvoke@http://localhost:8100/build/vendor.js:4982:24 F</l</t.prototype.invoke@http://localhost:8100/build/polyfills.js:3:14901 F</c</r.prototype.run@http://localhost:8100/build/polyfills.js:3:10124 NgZone.prototype.run@http://localhost:8100/build/vendor.js:4799:54 NavControllerBase.prototype._transitionStart/<@http://localhost:8100/build/vendor.js:56366:50 F</l</t.prototype.invoke@http://localhost:8100/build/polyfills.js:3:14974 onInvoke@http://localhost:8100/build/vendor.js:4982:24 F</l</t.prototype.invoke@http://localhost:8100/build/polyfills.js:3:14901 F</c</r.prototype.run@http://localhost:8100/build/polyfills.js:3:10124 f/<@http://localhost:8100/build/polyfills.js:3:20240 F</l</t.prototype.invokeTask@http://localhost:8100/build/polyfills.js:3:15649 onInvokeTask@http://localhost:8100/build/vendor.js:4973:24 F</l</t.prototype.invokeTask@http://localhost:8100/build/polyfills.js:3:15562 F</c</r.prototype.runTask@http://localhost:8100/build/polyfills.js:3:10815 o@http://localhost:8100/build/polyfills.js:3:7887

Teams now have their division name instead of the entire division object. Divisions know about their teams.

Update shouldUpdateEarlierMatches || shouldUpdateLaterMatches clause in schedule.ts so it won't thrash the server so much

Otherwise users will discover a page which is not useful because of meaningless data.

It is unnecessary when in 'production'

Remove now obsolete splash screen one too.

On 3rd December 2017 when I tried to filter to matches from 1st June 2017 - 31st September 2017 the following request is made:
https://snc-api.herokuapp.com/api/v0/matches?start=2017-10-26&end=2017-11-16
This date is clearly wrong.

Currently the app is in Ionic 3. It should be moved to Ionic Native if it's to properly be on mobile.

Due to ion-labels margins. Adding the *virtualItem to match-card and removing the ion-item wrapper

Indicate those that have passed already in some manner.

Suggestions:

• Put played matches in another tab
• Grey out displayed matches and focus on the next match
• Simply don't show previous matches

Or a refresh button. Something to refresh the schedule page without having to reopen the page/app.

So it is actually useful.