thomvis / construct Goto Github PK

After asking some advice in a Slack channel on using the legend, the expert advice was to attempt to ensure that the entire row is read as one sentence. For example;

"Mummy, HP: 64 of 58 including 8 temporary, AC: 11, Initiative modifier: -1"

I agree with this advice, though it has some implications;

• We should move the accessibility texts from the individual components to CombatantRow.
• Since the entire row would be one sentence, it can be considered to move the additional actions (update HP and roll initiative to the row's accessibilityActions.

That would be a bit of a change, so discussing this here first.

🙈

The following doesn't happen during regular building, but only when trying to preview a SwiftUI build in the Canvas.

Mostly this is just annoying, but it probably can be broken up into tinier pieces to alleviate this.

Xcode 12.2 beta 2

• master branch

/Users/brunoscheele/Projects/forks/Construct/Construct/Compendium/View/CompendiumItemDetailView.swift:29:16: The compiler is unable to type-check this expression in reasonable time; try breaking up the expression into distinct sub-expressions