thousandeyes / thousandeyes-sdk-go Goto Github PK

Hello,

Is it possible to get the response codes of http-server tests? Currently, there's a DesiredStatusCode field which returns the expected HTTP status code but I was not able to find a field for the actual responseCode.

I see the code is using /tests/testID.json for fetching the response which does not contain the responseCode field. However, the /web/http-server/testID.json does - https://developer.thousandeyes.com/v6/test_data/#/http-server.

Story

As a developer I would like client support to create transactions tests

Detail

Should have consistent API like other test support & similar test coverage

• Support Creating transactions tests
• Support Delete transactions tests
• Support Update transactions tests
• Support Get transactions tests

Story

As a developer I would like client support to create voice-call tests

Detail

Should have consistent API like other test support & similar test coverage

• Support Creating voice-call tests
• Support Delete voice-call tests
• Support Update voice-call tests
• Support Get voice-call tests

https://github.com/william20111/go-thousandeyes/blob/130ff0ecdcb28f8212e6925086939aa67f603858/http_server.go#L50

https://developer.thousandeyes.com/v6/tests/#/test_metadata

Details

As a developer using this library I would like to be able to control my thousandeyes account. So i can have my management of users and groups via code.

AC

• Account Group control - Get, Delete, Update, Create
• User control - Get, Delete, Update, Create

References

• https://developer.thousandeyes.com/v6/admin/

We need to add support for moving agents into and outof clusters.

Examples here

We should reognize contributions from the community on both of these projects. Looks like this free service can maybe help us with that. I would install it myself but I dont have permissions to do so in either of these repos...

https://allcontributors.org/docs/en/bot/installation

Story

As a developer I would like client support to create voice tests

Detail

Should have consistent API like other test support & similar test coverage

• Support Creating voice tests
• Support Delete voice tests
• Support Update voice tests
• Support Get voice tests

1. https://github.com/william20111/go-thousandeyes/blob/850c5703d1939f3d037a9757a8dd06581eeb4b5c/client.go#L246

We need to handle the case that the ConcurrentMessages list consists of all the past messages.

for i, t := range rate.ConcurrentMessages {
	if t.Sub(now) >= time.Duration(0) {
		rate.ConcurrentMessages = rate.ConcurrentMessages[i:]
		break
	}
        // Need to clear the list if it consists all the past messages, otherwise the delay will be increased for each incoming request.
	if i == (len(rate.ConcurrentMessages) -1) {
		rate.ConcurrentMessages = rate.ConcurrentMessages[:0]
	}
}

Story

I as a library consumer would like go-thousandeyes to support test type page-load. This is so i can create page-load tests via the API

Details

Implement interface like http-server for page-load

• Test API
• Test Metadata

Story

As a developer I would like client support to create dns-dnssec tests

Detail

Should have consistent API like other test support & similar test coverage

• Support Creating dns-dnssec tests
• Support Delete dns-dnssec tests
• Support Update dns-dnssec tests
• Support Get dns-dnssec tests

Story

As a developer I would like client support to create dnsp-domain tests

Detail

Should have consistent API like other test support & similar test coverage

• Support Creating dnsp-domain tests
• Support Delete dnsp-domain tests
• Support Update dnsp-domain tests
• Support Get dnsp-domain tests

Story

As a developer I would like client support to create ftp-sever tests

Detail

Should have consistent API like other test support & similar test coverage

• Support Creating ftp-server tests
• Support Delete ftp-server tests
• Support Update ftp-server tests
• Support Get ftp-server tests

What

The client should handle pageination for the developer using the library

Why

Could cause weird failures when querying large numbers of tests/agents

References

https://developer.thousandeyes.com/v6/#/pagination

Hey William,

I wanted to open the door to us having a discussion around the project structure and see if you would entertain a refactor of the code base to maybe make it more manageable ?

My thought process is is that we structure the project by domains, kinda like the AWS SDK does... what are your thoughts on this ?

-John

The ThousandEyes API misses updating back to empty fields. For example:

$ curl -d '{"contentRegex":"Needle"}' -H "Content-Type: application/json" -H "Accept: application/json" -H "Authorization: Bearer redacted" https://api.thousandeyes.com/v6/tests/http-server/<test_number>/update

$ curl -sd '{"contentRegex":""}' -H "Content-Type: application/json" -H "Accept: application/json" -H "Authorization: Bearer redacted" https://api.thousandeyes.com/v6/tests/http-server/<test_number>/update | jq | grep Needle
      "contentRegex": "Needle",

It happens in many fields, such as contentRegex, username, password, customHeaders, alertRules, etc.

This is a limitation. For example, it's not possible to disable alert rules entirely if an alert rule was already defined.

This issue has been reported internally and a fix is pending.

@william20111

I know you're probably busy so I was wondering if you might entertain granting me access to merge PR's for these two repositories ? Maybe that way I can help review and merge ?

Regards,

John

So today I was working on Labels and it turns out Labels can have Tests in its struct. Thats great however I am not sure how do that that since we have no top level Test type in the app... All tests actually should be part of this struct but I am not sure my Go is strong enough to know how to do that effectivly, since the tests struct would have to allow for a list of varying types ( ftp_server, dns_server, ect ect... ).. Do you have any strong opinions here ?

Also are you on Webex Teams or Discord by any chance ? or maybe we can setup Gitter for this repo to discuss?

Hello,

I was looking at this SDK and noticed that the NewClient only returns a *Client.

Returning an error along with a client like (*Client, error) would be a great help in case of any issues with the client.

Hello,

I noticed that there's no default value for DesiredStatusCode. The UI has a checkmark for Desired status code as Default (2xx or 3xx).

So, if a user doesn't specify the desired status code manually, DesiredStatusCode returns nil.

As a result, we cannot use the default checkmark in the UI and get a default response in the DesiredStatusCode field.

Details

As an developer using this library I would like to disable & enable agents via library

AC

• Add support for agent disable on the Agent struct
• Add support for agent disable on the Agent struct
• Add tests to cover new funcs

References

• https://developer.thousandeyes.com/v6/endpoint_agents/#/endpoint_agent_enable
• https://developer.thousandeyes.com/v6/endpoint_agents/#/endpoint_agent_disable