til-jmac / tableau-server-housekeeping Goto Github PK

Hi. Great job. Thanks.
I implemented it for my Tableau Server maintenance routine.

Suggestion: Cleanup section in the beginning of the script. Tableau recommends to clean up logs and temporary files before backing up to keep data files size smaller. Backup runs faster.

There are some minor errors I have corrected in my version:
1 - In the tsm maintenance backup command, the $backupname should be $backup_name.
2 - There is missing "echo" word command in the else statements when "found, deleting..." (both else statements).

Thanks for sharing.

We need to change the log-archives script zip format to .json format Can you please help on it

cd../../../../../../..
cd C:\Windows\System32\cmd.exe
cd ../..
cd C:\ProgramData\Tableau\Tableau Server\data\tabsvc\files\log-archives
tsm maintenance ziplogs -f archievedlogs -d -u -p
exit

I would change the line
sudo chmod +x /var/opt/tableau/tableau_server/data/scripts/tableau-server-housekeeping.sh
to
sudo chmod 700 /var/opt/tableau/tableau_server/data/scripts/tableau-server-housekeeping.sh
because of the cleartext password in the schript.

It will be very useful if you could add email notification with the status of Clean up logs and Bakcup.

In /tableau-server-housekeeping/windows/2019.2 and later/tableau-server-backup-script.cmd you look to have removed the command line options for tsm username and password. There is however still one occurrence in the script that is looking for these and this is causing the script to error and partially fail:

:: Grab the location of the backup directory
:set_backup_dir
ECHO %date% %time% : Getting the location of the default backup directory
FOR /F "tokens=* USEBACKQ" %%F IN (tsm configuration get -k basefilepath.backuprestore -u %tsmadmin% -p %tsmpassword%) DO (SET "backuppath=%%F")
ECHO The default backup path is:
ECHO %backuppath%

If you remove the -u %tsmadmin% -p %tsmpassword% from the script all then works correctly.

inside files

For example, to schedule it to run once a day at 01:00, add this to your crontab
0 1 * * * /var/opt/tableau/tableau_server/scripts/tableau-server-housekeeping-linux.sh > /home//tableau-server-housekeeping.log

but files names:
tableau-server-backup.bash
tableau-server-logs-cleanup.bash

copy pasted that to cron and looking why it didn't works)

the -v switch in the tsm maintenance cleanup call appears to be removed.

/linux/tableau-server-backup.bash

You define copy_backup="no"
but in
#copy backups to different location (optional)
if [ "$copybackup" == "yes" ];
you're missing the "_"