tilka / wii-banner-player Goto Github PK

Suggestion from giantpune (issue 3) processed in an easy to approve way :)

In Textbox.cpp, Textbox::Load(), as characters are read from the stream, you 
are reading a wchar_t at a time.  This code is not portable, and at least on my 
64bit linux and devkitPPC, a wchar_t is 32 bits wide.  If you change it to read 
only 16bits at a time, the letters are coming out like they are supposed to.

while (true)
    {
        u16 c;
        file >> BE >> c;

        if (c)
            text += (wchar_t)c;
        else
            break;
    }

Well, after testing some opening.bnr files, I really have to say I'm impressed. 
In such a little amount of time, you've made a lot of progress, and this 
program is more stable with every new released revision. However, that doesn't 
mean I haven't experimented problems (I know there are still some broken 
textures, but right now that's not the point). I hope you read this, so you can 
improve the Player.

1. First of all, the BNS playing problems. I don't know if it was the way I 
compiled the source (using Visual C++ 2010 Express, without compiling errors), 
but the sound didn't work in any of the banners I tested. And yes, I do have 
the libsndfile-1.dll in the player directory.

2. Secondly, I would like to request compatibility with the banner files from 
the WADs (00000000.app). As I told you on YouTube 
(http://www.youtube.com/watch?v=FxrSpAZD3ew), the header of those files is 
different than the one present in the opening.bnr ones. I got them working by 
unpacking them and repackaging the resulting *.bin files to a opening.bnr with 
the IMET DVD Banner Info header, using the U8Tool. I don't know if the source 
code of that program is available, but I think if you contact HowardC (its 
creator) he could at least give you some indications. And if you need a sample, 
I can upload one or two.

3. And last but not least, make the program ask which file do we want to play, 
instead of automatically load the opening.bnr present in the Player's 
directory. I think this would be a requirement if you decide to implement 
compatibility with the 00000000.app files.

And as I told you before, keep up the good work! This is an interesting project.

Can you port your code to build a library for devkitppc ?

Thx