timkoopmans / gridinit-jmeter

Moved to ruby-jmeter

gridinit-jmeter's Issues

exception when running basic example (undefined method `/' for {:count=>10}:Hash (NoMethodError))

When attempting to run the basic example below, I am getting an undefined method exception.

This is test that I'm trying to generate a jmx file for:

require 'gridinit-jmeter'
test do
  threads count: 10 do
    visit name: 'Google Search', url: 'http://google.com'
  end
end.jmx

This is exception stack trace:

/Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/threads/thread_group.rb:8:in `initialize': undefined method`/' for {:count=>10}:Hash (NoMethodError)
    from /Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/dsl.rb:87:in `new'
    from /Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/dsl.rb:87:in`threads'
    from /Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/helpers/fallback_content_proxy.rb:45:in `__proxy_method__'
    from /Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/helpers/fallback_content_proxy.rb:40:in`method_missing'
    from /Users/shoop/RubymineProjects/gridinit_stuff/sandbox.rb:4:in `block in '
    from /Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/dsl.rb:8:in`instance_eval'
    from /Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/dsl.rb:8:in `dsl_eval'
    from /Users/shoop/.rvm/gems/ruby-2.0.0-p195/gems/gridinit-jmeter-0.3.2/lib/gridinit-jmeter/dsl.rb:428:in`test'
    from /Users/shoop/RubymineProjects/gridinit_stuff/sandbox.rb:3:in `'
    from -e:1:in`load'
    from -e:1:in `'

Additional Info (for what it's worth):

• gems installed:
  Using nokogiri (1.5.9)
  Using mime-types (1.23)
  Using rest-client (1.6.7)
  Using gridinit-jmeter (0.3.2)
  Using json (1.7.7)
  Using bundler (1.3.5)
• Jmeter 2.9 installed

Same error with:

• MacOS 10.8.3 and Ubuntu 12.03
• Ruby 1.9.3 and 2.0.0
• gridinit-jmeter 0.2.8 and 0.3.2

I hope this is just a dumb mistake on my behalf. I'm very anxious to start using GridInit!

Please let me know if I can provide any further info.

support http parameters

Is there a way you are meant to pass url parameters into a visit call? The behaviour I am seeing is that they are getting stripped off the url, and not included in the resulting jmx

e.g. if you do this:

visit "example_with_parameters","http://example.com/test_url.html?something=something&this_is_another_parameter=present"

then the resulting jmx looks like this:

   <HTTPSamplerProxy guiclass="HttpTestSampleGui" testclass="HTTPSamplerProxy" testname="example_with_queries" enabled="true">
      <elementProp name="HTTPsampler.Arguments" elementType="Arguments" guiclass="HTTPArgumentsPanel" testclass="Arguments" testname="User Defined Variables" enabled="true">
        <collectionProp name="Arguments.arguments"/>
      </elementProp>
      <stringProp name="HTTPSampler.domain">example.com</stringProp>
      <stringProp name="HTTPSampler.port">80</stringProp>
      <stringProp name="HTTPSampler.connect_timeout"></stringProp>
      <stringProp name="HTTPSampler.response_timeout"></stringProp>
      <stringProp name="HTTPSampler.protocol">http</stringProp>
      <stringProp name="HTTPSampler.contentEncoding"></stringProp>
      <stringProp name="HTTPSampler.path">/test_url</stringProp>
      <stringProp name="HTTPSampler.method">GET</stringProp>
      <boolProp name="HTTPSampler.follow_redirects">true</boolProp>
      <boolProp name="HTTPSampler.auto_redirects">false</boolProp>
      <boolProp name="HTTPSampler.use_keepalive">true</boolProp>
      <boolProp name="HTTPSampler.DO_MULTIPART_POST">false</boolProp>
      <boolProp name="HTTPSampler.image_parser">true</boolProp>
      <boolProp name="HTTPSampler.concurrentDwn">true</boolProp>
      <boolProp name="HTTPSampler.monitor">false</boolProp>
      <stringProp name="HTTPSampler.embedded_url_re"></stringProp>
    </HTTPSamplerProxy>

And the parameters aren't included in the file anywhere.

Missing '<' on IfController

On line <stringProp name="IfController.condition">/stringProp>

Unable to do multiple entries in HTTP Header or User Defined Variables

I am unable to insert multiple entries into the HTTP Header or User Defined Variables config elements.

Only the last values are used on multiple entries and "fill_in" has no effect.

Not sure if this is just a missing feature, a bug or if I am simply doing it wrong. An example or any help would be appreciated.

Thanks.

Where there were line breaks in a query string in Ruby we got newline chars in the sent parameters

License missing from gemspec

Some companies will only use gems with a certain license.
The canonical and easy way to check is via the gemspec,

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Even for projects that already specify a license, including a license in your gemspec is a good practice, since it is easily
discoverable there without having to check the readme or for a license file. For example, it is the field that rubygems.org uses to display a gem's license.

For example, there is a License Finder gem to help companies ensure all gems they use
meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough
issue that even Bundler now generates gems with a default 'MIT' license.

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), github has created a license picker tool.

In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :).

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue and let me know. In either case, I'll follow up. Thanks!

p.s. I've written a blog post about this project

Parameter ':method' is ignored on the visit directive.

Calling

visit 'Google Search', 'http://altentee.com', {
  method: 'POST', 
  DO_MULTIPART_POST: 'true'
}

Will generate the jmx file with the "GET" method. This is due setting the :method parameter.

Pull request combing.