timoetting / kirby-color Goto Github PK

When focusing another field to blur the color picker, the blur event does not trigger. To hide the color picker you will then have to re-focus the field and click somewhere else:

The value in the field for the alpha channel in RGB and HSL modes in the color picker exceeds the allowed maximum of 1 if I’m using the “up” arrow key of the keyboard while the field is focused.

This plugin doesn't work when the color field is used as field in a structure...

Error shown: Cannot read properties of undefined (reading 'rgba').

Easy to replicate; add following in a structure:

color:
  type: color
  editableAlpha: false
  label: Colour

It would be nice if the plugin offered a way to specify the output color format used for storage (hex, rgb, hsa).

Alternatively, it would also be an idea to offer functions to convert color formats inside templates.

If the default value is set to nothing (empty), adding a color for the first time doesn’t trigger a content change event (or whatever it is called when the bar with the save and revert buttons is triggered). One has to change the color again to be able to save the page. I’d expect it to trigger this bar even if no default color is set.

can be closed. the issue was not in the plugin!

Hi! I think the dev version (1.8MB large & with HMR code) was committed to the latest revision.
I guess the production version (npm run build) should be committed instead. :)

Hi @TimOetting !

What is the status/plan/timeframe for the color picker ?
Kirby is at RC–4, release date set to 15 januari.

Best regards /

Fredrik

If a color is selected for the first time (i. e. no color was selected previously), clicking “revert” in the bottom bar brings up the error message “this.color is null” in the place of the color field. It should revert to the unspecified state in which it was previously.

Any plan to release it on composer ?

the plugin as it breaks the current version of markdown-field :(

apart from the index.js file being massive with 1.8MB (forks bring it down to 20kb) this plugin might be causing other plugins not to work because of this issue:

https://github.com/getkirby/ideas/issues/135

-- pls delete --

I love the plugin and have moved from the other Colors plugin to this because of the UI and presets.

I'm having an issue in the Panel: when the color is set to a blank string, I get the error undefined is not an object (evaluating 'this.colors.rgba') and the field is not displayed. In my use, the color is optional, so it will sometimes be blank. (I don't want it to be set to a default color, I just want it to be blank.)

I can't find where the error is coming from, but if you can point me in the right direction I'd be happy to investigate it further. If it is relevant, I'm using this in a Structure field.

Thanks for this helpful plugin.

In order to handle different use cases, it would be nice if the field offered settings for the UI components shown in the color picker. I'm not sure how flexible the underlying Vue component is, but I'm thinking about something like this:

color:
  label: Color
  type: color
  components: 
    - saturation: true
    - hue: false
    - input: false
    - presets: true
  presets:
    - "#fff"

This way, it would be possible to create a color picker with presets only or one that only offers the hex, rgb and hsa inputs.

If editableAlpha: false is set, the RGB and HSL modes of the color picker show “RGA” and “HSA” instead, i. e. it seems like the third field is hidden (i. e. “blue” in RGB mode and “lightness” in HSL mode) and the field for the alpha channel is still shown instead (albeit not properly usable).