timomeh / hey-pane Goto Github PK

I'm having the same issue as another person who's ticket is now closed, it just started working for him again after a while.

As requested, I looked in dev tools and my active pane does not have the hey-pane-focus class. Flex-grow changes when I resize the pane manually.

I've tried switching the keybinding to something else, but it just won't fire.

Here is a list of my installed packages:
https://gist.githubusercontent.com/ehellman/6ccf288440808c1c2da2c205baa11530/raw/4eb50972689f6175be44b6d72861a3ae1db1331f/packages.json

Started to appear after updating to latest Atom Beta version (was released today I believe).

1. Open Atom Beta (https://atom.io/beta)

Atom: 1.16.0-beta0 x64
Electron: 1.3.13
OS: Mac OS X 10.12.3
Thrown From: hey-pane package 0.2.1

Stack Trace

Failed to load the hey-pane package

At /Users/nicklas/.atom-beta/packages/hey-pane/lib/hey-pane.js: package is a reserved word in strict mode (134:43)

SyntaxError: /Users/nicklas/.atom-beta/packages/hey-pane/lib/hey-pane.js: package is a reserved word in strict mode (134:43)
  132 | 
  133 |   checkIncompatiblePackages(package) {
> 134 |     if (this.incompatiblePackages.includes(package.name)) {
      |                                            ^
  135 |       atom.notifications.addError('Incompatible Package Detected',
  136 |         {
  137 |           dismissable: true,
    at /app.asar/node_modules/babylon/lib/index.js:4373:13)
    at /app.asar/node_modules/babylon/lib/index.js:4270:10)
    at /app.asar/node_modules/babylon/lib/index.js:4243:10)
    at /app.asar/node_modules/babylon/lib/index.js:3581:21)
    at Parser.parseExprAtom (/app.asar/node_modules/babylon/lib/index.js:7016:22)
    at /app.asar/node_modules/babylon/lib/index.js:3427:19)
    at /app.asar/node_modules/babylon/lib/index.js:3407:19)
    at /app.asar/node_modules/babylon/lib/index.js:3337:19)
    at /app.asar/node_modules/babylon/lib/index.js:3314:19)
    at /app.asar/node_modules/babylon/lib/index.js:3277:19)
    at Parser.parseMaybeAssign (/app.asar/node_modules/babylon/lib/index.js:6242:20)
    at /app.asar/node_modules/babylon/lib/index.js:4231:16)
    at Parser.parseExprListItem (/app.asar/node_modules/babylon/lib/index.js:5913:29)
    at /app.asar/node_modules/babylon/lib/index.js:3506:20)
    at /app.asar/node_modules/babylon/lib/index.js:3466:31)
    at /app.asar/node_modules/babylon/lib/index.js:3437:15)
    at /app.asar/node_modules/babylon/lib/index.js:3407:19)
    at /app.asar/node_modules/babylon/lib/index.js:3337:19)
    at /app.asar/node_modules/babylon/lib/index.js:3314:19)
    at /app.asar/node_modules/babylon/lib/index.js:3277:19)
    at Parser.parseMaybeAssign (/app.asar/node_modules/babylon/lib/index.js:6242:20)
    at /app.asar/node_modules/babylon/lib/index.js:3239:19)
    at /app.asar/node_modules/babylon/lib/index.js:3722:18)
    at /app.asar/node_modules/babylon/lib/index.js:2013:20)
    at /app.asar/node_modules/babylon/lib/index.js:1801:19)
    at Parser.parseStatement (/app.asar/node_modules/babylon/lib/index.js:5712:22)
    at /app.asar/node_modules/babylon/lib/index.js:2223:21)
    at /app.asar/node_modules/babylon/lib/index.js:2202:8)
    at /app.asar/node_modules/babylon/lib/index.js:4154:22)
    at Parser.parseFunctionBody (/app.asar/node_modules/babylon/lib/index.js:5699:20)

Commands

Non-Core Packages

autocomplete-paths 1.0.5 
date 1.2.2 
file-icons 2.0.17 
gfm-lists 1.0.0 
hey-pane 0.2.1 
imdone-atom 2.1.22 
jumpy 3.1.3 
minimap 4.26.8 
minimap-find-and-replace 4.5.2 
minimap-highlight-selected 4.5.0 
quick-file-actions 0.1.1 
recent-files-fuzzy-finder 0.3.0 
textual-velocity 0.12.4 
toggle-markdown-task 0.6.0 
vim-mode-plus 0.83.0 
wikilink 0.14.0 
zentabs 0.8.8 

Title should say it all. If you are on Linux or Windows, we use ctrl, not cmd 👍

I find myself having to re-enable follow mode every time I start up atom. Looking at the code it would be very simple to add a setting to enable it by default and turn on follow mode on start up if that setting is checked. I have hacked it to work on my machine and I can share how I did it if you would like.

Not An issue just wanted too know what it was.

@timomeh Can you take a look ?

Full pane editing area somehow locked into a very small section.

In this photo, I have two panes open side by side: Settings and a file. However, both of them take up a very small portion of the total screen.

The width of the area in which I can put panels cannot be changed by using multiple panes side by side or any other method I have tried. There is also no resizing functionality.

I have not been able to add or move any sort of pane into the large blank space, only within the small strip.

I have tried disabling Hey Pane and restarting atom to no avail. The Hey Pane commands also do not fix this issue.

As this issue persists even with Hey Pane disabled, Atom becomes fully unusable with this bug.

Editor-area is no longer visible when using https://atom.io/packages/vertical-tabs package.

I guess the problem can be fixed manually by setting a wider size, once you implement configurations, but I reckon it could be larger to begin with when certain conditions are met (such as having aforementioned package enabled).

Sorry for stupid question: What is the widget that is showing your keystrokes in the lower right of the the README.md GIFs?

whether it supports win? if so, how to use , thanks a lot

It'd be great if we could enable (or auto-enable) follow mode only if we're already in focus mode (fullscreen), and when we exit focus, auto-disable follow mode.

After installing this package, I noticed that it don't work on Windows. I mean, Shift-Ctrl-K instead of Shift-Cmd-K that seems a Mac shortcut. I modified the keymap.json file substituting shift-cmd-k with shift-ctrl-k, but ti didn't work. Any advice?

Love this package. Use it constantly.

Thanks!

Problem

I think this plugin is nice, but I'd like it to work on the settings panel as well.
I am not against opening a PR but not sure where to start. I'll go looking into the src if you tell me where to look. 🥇

My System

$ atom --version
Atom    : 1.14.3
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

OS: Mac OS X El Capitan

@timomeh After fix #6 I got this deprecation:

atom.workspace.paneContainer has always been private, but it is now gone. Please use atom.workspace.getCenter() instead and consult the workspace API docs for public methods.

Workspace.get (<embedded>:24619:18)
resursiveSet (/Users/jerrylee/.atom/packages/hey-pane/lib/hey-pane.js:105:48)
Object.doFocus (/Users/jerrylee/.atom/packages/hey-pane/lib/hey-pane.js:112:5)
Object.toggleFocus (/Users/jerrylee/.atom/packages/hey-pane/lib/hey-pane.js:70:52)
atom-workspace.heyPaneToggleFocusOfActivePane (/Users/jerrylee/.atom/packages/hey-pane/lib/hey-pane.js:37:22)
CommandRegistry.handleCommandEvent (<embedded>:18796:35)

I am loving this extension! However, one of the painpoints for me on follow mode is when I need to copy a single value from a small pane for use in a large pane. As I'm preparing to copy, the small pane ends up reflowing and changing the location of the item to copy, then again as I switch back.

Perhaps there could be a programmable delay, or some other UI option or feature to help solve this issue?

First. Really useful tool and THX for sharing it.

When I'm in hey-pane mode and close atom, the same view is present when reopen atom.
But using my keyboard-shortcut for hey-pane doesn't change back to the default view.
So I need to reorganize that view.

Solution till now is only to leave hey-pane mode before closing atom, but I forgot that quite often.

As per @mrleblanc101's comments on #12 I'm creating a new issue for separate discussion.

I think it would be nice if you could set a 'minimum' dimension in absolute value that a pane will be reduced to. This way you can try to resize a pane split to 90% / 10% but the smaller pane will not go below 200px.

I personally set my separation to around 60% so this isn't a big issue for me, but this seemed like a straightforward way to fix the problem for others.

The real problem is that you squish the content making it look really unpleasant and distracting.
There should be an absolute mode where the pane overlaps each other instead of being squished.
It also causes conflict with the minimal plugin as you can see in the screenshot below.

Then setting pane looks good because it's content doesn't get squished or wrapped over multiple lines

Panes change focus when follow mode is on and the side panels such as tree view are clicked. It's really frustrating to click on a file in the tree to preview it and have the file open in a pane only to then have that pane instantly squished as another pane is focused. Let me know if I can provide any more detail or if I can help in any other way.

everything is reporting an error. It says 1.15 is out of date and i should upgrade to 1.21, it will not run the upgrade. and every new entry meets a new error. Any tips

Ali

[Enter steps to reproduce:]

1. ...
2. ...

Atom: 1.15.0 x64
Electron: 1.3.13
OS: Mac OS X 10.12.6
Thrown From: hey-pane package 1.0.0

Stack Trace

Uncaught TypeError: atom.workspace.getCenter is not a function

At /Users/thecorletts/.atom/packages/hey-pane/lib/hey-pane.js:72

TypeError: atom.workspace.getCenter is not a function
    at Object.doFocus (/packages/hey-pane/lib/hey-pane.js:72:37)
    at Object.startFollow (/packages/hey-pane/lib/hey-pane.js:54:10)
    at /packages/hey-pane/lib/hey-pane.js:49:53
    at Function.module.exports.Emitter.simpleDispatch (/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at stoppedChangingActivePaneItemCallback (/app.asar/src/pane-container.js:352:36)

Commands

     -4:21.8.0 core:save (input.hidden-input)
     -1:33.1.0 core:move-right (input.hidden-input)
     -1:30.2.0 core:save (input.hidden-input)
  2x -1:04.2.0 core:backspace (input.hidden-input)
     -0:36.5.0 hey-pane:toggle-focus-of-active-pane (input.hidden-input)

Non-Core Packages

atom-ftp-editor 0.5.0 
atom-material-ui 1.3.10 
browser-plus 0.0.98 
ftp-remote-edit 0.12.3 
hey-pane 1.0.0 
open-in-browser 0.5.2 

I'm not a frontend guy, so perhaps this is more resource intensive or difficult than I'm thinking, but everything kind of 'jerks' when one switches panes currently. I would suggest have an option to slide, to make it a bit smoother.