GithubHelp home page GithubHelp logo

timrwood / roost Goto Github PK

View Code? Open in Web Editor NEW
14.0 6.0 16.0 727 KB

A Minecraft mod that gives chickens a place to rest

Home Page: https://minecraft.curseforge.com/projects/roost

License: MIT License

Java 100.00%

roost's Introduction

Roost

CurseForge

A Minecraft mod that gives chickens a place to rest.

roost's People

Contributors

benblank avatar codewarrior0 avatar dycoldwind avatar lykrast avatar timrwood avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

roost's Issues

[1.12.2] Roost Chicken In Tabs

That little chicken at the end of the GUI seems to be appearing in every single creative tab:

image

image

Would love a fix for this so I can use this mod with the newly updated Chickens mod.

Add HWYLA support

  • Roost chicken with stats
  • Roost drop progress
  • Breeder chickens
  • Breeder drop progress
  • Breeder errors (no seeds)

Chickens Catcher can dupe chickens with a macro

If you have a keyboard/mouse/autohotkey macro that sends the 'use' button very quickly you can dupe chickens. It happens in single player and on a server.

Example video here

Minecraft: 1.12.2
Forge: 14.23.2.2624
Roost: 1.12-1.2.0

[suggestion] ContentTweaker support

contenttweaker lets you manually add in brand new chickens, which are automatically picked up by roost, but they all lack textures and any attempt to hack them in manually via resourcepacks/loaders seems to be failing

QA Checklist

Blocks

Roost

  • Can be crafted
  • Has localized name
  • Textures look correct
  • All modded chicken textures look correct
  • Can insert a chicken with right click
  • Can remove a chicken with shift+right click
  • Does not replace vanilla chicken with modded chicken on right click
  • Does not replace modded chicken with other modded chicken type on right click
  • Does not replace modded chicken with same modded chicken with other stats on right click
  • When roost has 15 chickens, right clicking with 1 of same chicken will add to stack correct amount
  • When roost has 15 chickens, right clicking with 2 of same chicken will decrement held stack to 1
  • When roost has 16 chickens, right clicking with 1 of same chicken will open GUI
  • Vanilla drops feathers and eggs
  • Modded drops correct item
  • Drop progress does not reset when reloading world
  • Hoppers can put chickens in
  • Hoppers can not put anything in drop slots
  • Hoppers pull drops out
  • Hoppers do not pull chicken out
  • [GUI] Shows drop progress on hover
  • [GUI] Middle click fills chicken slot
  • [GUI] Middle click does not put anything else in chicken slot
  • [GUI] Middle click does not put anything in output slots
  • [HWYLA] Shows vanilla chicken type
  • [HWYLA] Shows modded chicken type with stats
  • [HWYLA] Shows drop progress
  • [HWYLA] Empty roost shows no progress

Breeder

  • Can be crafted
  • Has localized name
  • Textures look correct
  • Privacy textures look correct
  • 2 vanilla chickens create a vanilla chicken
  • 1 vanilla + 1 modded create both vanilla chickens and cloned modded chickens
  • 2 modded of same type create improved chicken of same type
  • 2 modded of different types create type a, type b, and cross breed type
  • Breeding uses 2 seeds
  • Breeding progress does not continue when there are not enough seeds
  • Breeding progress does not reset when reloading world
  • Hoppers can put seeds in
  • Hoppers can put chickens in
  • Hoppers can not put anything in drop slots
  • Hoppers pull child chickens out
  • Hoppers do not pull parent chickens out
  • [GUI] Shows drop progress on hover
  • [GUI] Middle click fills chicken slots
  • [GUI] Middle click does not put anything else in chicken slots
  • [GUI] Middle click does not put anything in output slots
  • [HWYLA] Shows vanilla chicken types
  • [HWYLA] Shows modded chicken types with stats
  • [HWYLA] Shows drop progress
  • [HWYLA] Show when there are no seeds
  • [HWYLA] Empty breeder shows no progress

Collector

  • Can be crafted
  • Can be crafted with modded chicken
  • Has localized name
  • Textures look correct
  • Pulls items from roost 4 blocks north and 4 blocks west
  • Pulls items from roost 4 blocks south and 4 blocks east
  • Pulls items from roost 2 blocks above
  • Hoppers can pull items out
  • Hoppers can put items in
  • [GUI] Can shift+click item in and out

Items

Chicken

  • Has correct texture
  • Has correct texture for modded
  • Vanilla chicken spawns a vanilla chicken on right click
  • Modded chicken spawns a modded chicken on right click
  • Modded chicken spawns a modded chicken with the correct stats on right click
  • Vanilla chicken has localized name
  • Modded chickens have localized names
  • [JEI] Has localized name in recipe display

Chicken Catcher

  • Can be crafted
  • Has localized name
  • Has correct texture
  • Can catch a vanilla chicken
  • Can catch a modded chicken with correct stats

Integrations

Chickens

  • Has all chicken item textures
  • Has all roost chicken textures

More Chickens

  • Has all chicken item textures
  • Has all roost chicken textures

Ore Dictionary Missing/not utilized

Currently playing FTB Sky Adventures. I updated Roost to 1.3.0. Attempting to use RFTools Storage Control Screen module to setup a display for counting the individual chickens in the roosts. Roost doesn't seem to utilize the chickens as different oredicts and are instead all generic chickens so RFTools (and other mods) treat them all as the same item. The only exception I've found that will treat them differently is EnderIO due to the usage of NBT data. When attempting to move/count/manage chickens as items, ignoring NBT with EnderIO allows you to use 1 chicken cover all chickens or don't ingore NBT to count individual chickens. Is it possible to setup Ore Dictionaries to allow for each chicken item to be counted/managed individual with/without ore dictionaries?

Looking at Chicken 2D sprites in JEI is causing RAM/GC to spike

If you hit F3 for the debug overlay, then look at either @Roost or looking at "breeding chickens" or "roosting chickens", the ram usage speed in the top right-hand corner increases by like 200%.

By RAM I mean when the ram usage is going up and then gets reset by garbage collection. When viewing these sprites the usage increase triples and it goes crazy. Note this doesn't happen with the chicken's mod JEI (their own breeding JEI etc.)

This seems to only be a problem with Roost.
Furthermore, the chickens in the actual roost are fine, and don't show any issues. Seems to be a conflict with roost and JEI.

Using: Roost: 1.12.2-1.3.0
JEI: 1.12.2-4.14.4.264

Edit: note that this occurs regardless of chickens and more chickens version

Clarify license

The CurseForge page that distributes this mod says Roost uses the MIT license, but the source code repo just has copies of Forge's license and readme files. Which one is correct? Would you mind putting that in the repo and removing whichever any existing bits that aren't relevant?

Thanks!

[Server thread/FATAL]: Error executing task

As sone as i put a chicken in the Roost i get the following error message every second:
[Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NoClassDefFoundError: net/minecraft/client/resources/I18n
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_144]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_144]
at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:387) [ld.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:613) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:471) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
Caused by: java.lang.NoClassDefFoundError: net/minecraft/client/resources/I18n
at com.timwoodcreates.roost.data.DataChicken.getDisplayName(DataChicken.java:141) ~[DataChicken.class:?]
at com.timwoodcreates.roost.data.DataChicken.getDisplaySummary(DataChicken.java:149) ~[DataChicken.class:?]
at com.timwoodcreates.roost.tileentity.TileEntityRoost.storeInfoForTooltip(TileEntityRoost.java:102) ~[TileEntityRoost.class:?]
at com.timwoodcreates.roost.integration.waila.RoostWailaDataProvider.getNBTData(RoostWailaDataProvider.java:65) ~[RoostWailaDataProvider.class:?]
at mcp.mobius.waila.network.MessageRequestTile$Handler$1.run(MessageRequestTile.java:97) ~[MessageRequestTile$Handler$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_144]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_144]
at net.minecraft.util.Util.func_181617_a(SourceFile:45) ~[h.class:?]

Could you take a look at this?

Minecraft version 1.10.2

Bug With + and - %

Hello, I found BUG after installed mods "Ender IO and Ender Core" on server.
FTB Presents DireWolf20 1.12 (v1.9.0)
Minecraft Forge : 14.23.2.2618
Roost : 1.2.0

165

68

-35 breed

Possible Animania integration?

I like this mod much more than Hatchery. While they do mostly the same thing, this one has much nicer textures and more fits with the original tone of the game.
However, I still mostly use Hatchery instead, and that is because it's compatible with Animania a mod which I use quite frequently. Is there a possible Animania integration?

Animania's source code is here:
https://github.com/capnkirok/animaniamod

Config?

I cannot seem to locate a configuration file for this mod, and I need to turn down the speed of both breeding and how fast items are produced because it's causing a major balancing issue. If someone could direct me on how to configure breeders and roosts it would be much appreciated.

Breeder Extraction

In order to breed up better chickens, it is necessary to replace at least one of the breeding pair with an improved offspring. However, this can't be automated because the breeding pair slots seem to be input-only.

I'd like to request that the top (or front, back, bottom, etc) of the Chicken Breeder give extraction access to those two slots so the previous chickens can be removed and replaced through automation.

Add feather drops to breeder

It would be nice to also have feather drops from the breeder, not just the chicken. Rationale here being that during reproductive action the little critters will be highly active which then makes the feathers fly.

I presume that at least one feather per chicken bred would be ok. However, adding more breeding chicken to the mix, and thus speeding up the breeding action, more feathers could be dropped as well.

And, yes, I am tired of taking the bred chicken and slaying them for getting the precious feathers...

Crafttweaker Integration

Currently making an expert mode chickens based pack and tried to remove the breeding recipe for the roost refined iron as i can make other recipes for it, but ran into a problem with the removal of recipes. Is this a problem with roost or user error? Could be either in my case.

[Suggestion] Cross breeding leveled chickens

Currently successfully cross breeding two maxxed chickens only gives a regular chicken with no stats. I think it would be best if each stat of any two chickens being crossbred was averaged and then halved to give the stats of the child chicken.
Example:
Two chickens, Log chicken with stats 4/2/4, Flint chicken with stats 8/6/8. The average of each stat makes 6/4/6, half of each stat makes 3/2/3 resulting in a coal chicken with stats 3/2/3.

Making Breeder Chickens extractable

It would be a great thing if u could extract the two parent chickens somehow.
This would be a great addition to automate breeding or maxing out chickens.

Issue with Roost Percentage during breeding

Heyo there,

I wanted to mention this issue : it happens on my 1.12.2 when anyone uses the breeding.
Is there any known issue with this with any mod or is this something happening in roost ?

Placing 2 chickens in the breeder will make it go reverse, at one point this can change to the other example where it will count down again for some reason.

roost_timer
roost_reverse_breeding_timer

Collector code oddity

This isn't an issue per say.

I was looking at the code to determine how high you could stack the roosts to have the collector collect from them. That information wasn't noted in the overview. (It's 3 if I'm reading the code right)

But looking at your the code, the collector seems to have odd behavour because of the update to the search offset before doing the gather. The search offset is initialized at zero which would mean your first collection would be at x-4, y-0, z-4 if you did the gather first. But you increment the offset first so your first collection would be at x-4, y-0, z-3. It only gets to the x-4, y-0, z-4 position after you have checked/done all the other spaces.

The code works, but I'm not sure if it's working as you intended. My feeling is that you might consider doing the gatherItems() first, then the updateSearchOffset() in your update() of the collector.

Kzorith

1.10.2 Item Texture problem

Texture from Actually Addition , Refined Storage , Mekanism and Extra Utilities chicken won't load
(test done with and without texture pack)

Minecraft version 1.10.2
Forge Version 18.3.2511
Roost version 1.10.2-1.1.0

Is it possible to fix it please ?

roost

Occupied Roost breeders disappear

Bug Report

After update to 1.3.0, the roost breeders that had chickens in them all disappeared. I was in the mining dimension and when I returned to the overworld, my breeder that was unoccupied was normal. The other 9 appeared to be shadows on the wall. Logged out and back in and they were completely gone. Restored from back-up, repeated steps and they were still gone. No crash, no error messages. Am going to try an older version where I was in the overworld to see if this still happens. And it does.

Steps to Reproduce (for bugs)

Saved game while in mining dimension.
Updated modpack and started game. Received message about 3 blocks missing.
Changed from mining dimension to overworld. (Not a dimension shifting problem)
All occupied roosts missing. Unoccupied roosts are just fine.
Logs

Client/Server Log: 1 of 3: <script src="https://pastebin.com/embed_js/wT6KyAkb"></script>
2 of 3: <script src="https://pastebin.com/embed_js/PuT59BHZ"></script>
3 of 3: <script src="https://pastebin.com/embed_js/7mqVaXcP"></script>
Crash Log:

Vein mining the Roosts

I am on modpack Stone Block, when vein mining a wall of Roosts only the items in the roost you are clicking on drop their items, all the items and chickens in the other Roosts do not appear and the roosts are empty when replacing them in the world.

[Suggestion] Breeders active/idle visuals

I'm not sure if this is viable in terms of efficiency, but I'd love to see when my Breeders are actively working (chickens + at least 2 seeds are inside).

Right now there is visual effect after finishing each breed, which let's you know when it's done, but after that effect disappears it's not possible to distinguish between breeders.

Main reason behind changing that is improving chickens to 10/10/10 takes quite some time, and personally I'm doing it by placing 2 chickens and 4 seeds to breed 2 better chickens, and repeat the process. When doing it with multiple species at the same time it's very time consuming to check all breeders if they are done.

Lunar Reactive Dust chicken not spawning

When putting Redstone Chicken and Lapis Blue Chicken together in the roost you only get Lapis Blue and Redstone chickens not the intended Lunar Reactive Dust one.

Catching Smart Chickens turns them into vanilla chickens

[Running in 1.12.2] Tested this in creative mode and having the same issue and only with Smart Chickens. It seems the chicken catcher is converting them on pop to vanilla chickens. I can piggyback pack them to my roost area, but it looks like sticking them in a roost is out of the question.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.