app.use(<path>, <Router>) is Incompatible with Express about tinyhttp

[hpandelo]

Also good to mention:

import { App, Request, Response } from '@tinyhttp/app'

const router = new App().route('/home') /* Won't register the /home */

router.get('/', (_req: Request, res: Response) => {
  res.status(200).json({ message: 'Welcome' })
})

export const MainRouter = router

To have a way to set the base/root path together into the Router file will be awesome

[aarontravass]

Hi @hpandelo thanks for reporting these errors. I do have 1 thing to point out

// pushMiddleware(MainRouter.middleware) /* Not Working */

pushMiddleware is an internal method and is generally not supposed to be used by the user. Moreover, the syntax you have used it incorrect as well. See below for it's usage internally.

tinyhttp/packages/router/src/index.ts

Lines 212 to 218 in 54d95f0

	pushMiddleware<Req, Res>(this.middleware)({
	path: arg,
	handler: handlers[0],
	handlers: handlers.slice(1),
	method,
	type: 'route'
	})

[aarontravass]

One way to use app.use(MainRouter.middleware) would be to extract the handler and then pass. Like this
app.use(MainRouter.middleware.map(m => m.handler))

[hpandelo]

There are some ways to make it work, but won't be compatible with the usage in Express

It should be like:
app.use('/home', MainRouter) & app.use(MainRouter)

[aarontravass]

but won't be compatible with the usage in Express

Yes. There's also an existing issues but that is related to types #387

[hpandelo]

Another point, by using this way:
app.route('/home').middleware.push(...MainRouter.middleware)

Middlewares and settings wont work

export const app = new App({
  noMatchHandler: ...
  onError: ...
  settings: {
    networkExtensions: true,
    xPoweredBy: 'NeoX',
  },
})

xPoweredBy for example with a custom string or with false (also with app.use(helmet()) only will be affecting the routes from app.ts file, all the others "pushed" from Router() won't work (still returning the x-powered-by: tinyhttp)

[aarontravass]

Middlewares and settings wont work

Yes, that is due to the fact that route returns a new instance.

tinyhttp/packages/app/src/app.ts

Lines 264 to 270 in 54d95f0

	route(path: string): App {
	const app = new App()
	this.use(path, app)
	return app
	}

[talentlessguy]

tinyhttp author here

a few things:

1. @tinyhttp/router is an internal package and is a barebones router without most of the tinyhttp's logic. basically it's just a fancy thing to manage middleware arrays. you can't use both app and router. Just use the app package.

2. app.use(<path>, <app>) is working as expected and passes in tests, see example https://github.com/tinyhttp/tinyhttp/blob/master/examples/subapps

basically the correct way is this:

const app = new App()
const subapp = new App()
subapp.get('/', (req, res) => res.json({ hello: 'world' }))
app.use(subapp)

3. subapps created via app.route not respecting parent app's settings is a bug and should be filed as a separate issue (PR welcome)

if there's anything left unclear, pls lmk