GithubHelp home page GithubHelp logo

Comments (20)

Amanieu avatar Amanieu commented on June 12, 2024 3

This was stabilized in 1.72.

from ahash.

bk2204 avatar bk2204 commented on June 12, 2024 3

I'd greatly appreciate it if we could solve this problem without bumping the MSRV. I try to provide support for older versions of Rust, and Debian stable offers 1.63, which I'd like to continue to target.

from ahash.

matthiasg avatar matthiasg commented on June 12, 2024 3

This still happens on M1 with rust 1.78.0 nightly. Is there something I am missing ?

from ahash.

ozgrakkurt avatar ozgrakkurt commented on June 12, 2024 2

still doesn't compile on m1 with stable toolchain with this error

from ahash.

alamb avatar alamb commented on June 12, 2024 1

Proposed fix #196

from ahash.

djc avatar djc commented on June 12, 2024 1

FWIW, I'm running into this too (when trying to upgrade ahash in hickory-dns on my M1 with Rust 1.67).

from ahash.

alexeykhan avatar alexeykhan commented on June 12, 2024 1

Same for me here (M1):

  • rust 1.77.0-nightly - works fine
  • rust 1.78.0-nightly - error[E0635]: unknown feature stdsimd
    --> /Users/alexeykhan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.7.7/src/lib.rs:33:42
    |
    33 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
    | ^^^^^^^

For more information about this error, try rustc --explain E0635.
error: could not compile ahash (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

from ahash.

Amanieu avatar Amanieu commented on June 12, 2024 1

Are you using the latest version of ahash? Try cargo update.

from ahash.

tkaitchuck avatar tkaitchuck commented on June 12, 2024

@Amanieu It looks like this is caused by #183
Should I revert it or is there a better way?

from ahash.

Amanieu avatar Amanieu commented on June 12, 2024

These functions are stable, are you using an older version of rustc?

from ahash.

Anton-4 avatar Anton-4 commented on June 12, 2024

Oh right, I didn't think to check that. I'm on 1.71.1. Would it be possible to set the required minimum version with the rust-version field in the Cargo.toml? That should provide a nice error message in this case.

from ahash.

tkaitchuck avatar tkaitchuck commented on June 12, 2024

I am attempting to expand the presubmit checks to cover this #197
but so far it is still passing. What combination am I missing?

from ahash.

alamb avatar alamb commented on June 12, 2024

What combination am I missing?

I left a suggestion: #197 (comment)

from ahash.

tkaitchuck avatar tkaitchuck commented on June 12, 2024

@Anton-4 Can you clearify, you saw this when targeting aarch64-apple-darwin ? What args / rust flags were passed?

from ahash.

Jefffrey avatar Jefffrey commented on June 12, 2024

For datafusion, the issue came from apache/arrow-datafusion#8743

Tagging @Ted-Jiang who reproduced the issue

An example of the dependency datafusion has:

https://github.com/apache/arrow-datafusion/blob/e7cc04db68a05ce9d002de7d0c1be2644bf69c0c/datafusion/common/Cargo.toml#L41-L43

  • Located in a few other crates within datafusion too, but is essentially the same (version & features)

from ahash.

Anton-4 avatar Anton-4 commented on June 12, 2024

Can you clearify, you saw this when targeting aarch64-apple-darwin ?

Yes indeed, I'll set up a minimal github repo with a full reproduction.

from ahash.

Anton-4 avatar Anton-4 commented on June 12, 2024

Files for minimal repro:

// rust-toolchain.toml 
[toolchain]
channel = "1.71.1"

// Cargo.toml 
[package]
name = "temp2"
version = "0.1.0"
edition = "2021"

[dependencies]
ahash="=0.8.7"

// src/main.rs 
fn main() {
    println!("Hello, world!");
}

run with cargo build --target=aarch64-apple-darwin.
That produces the error for me on NixOS (x86_64 device) and also on macos 14 (m2 device).

from ahash.

iesahin avatar iesahin commented on June 12, 2024

I have the same issue in https://github.com/iesahin/xvc/actions/runs/7798376079/job/21266895940#step:9:1

from ahash.

Amanieu avatar Amanieu commented on June 12, 2024

To anyone hitting this error on nightly: you need to update your nightly compiler.

from ahash.

undenuicap avatar undenuicap commented on June 12, 2024

1.78.0-nightly is latest and not working with it :-(

from ahash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.