Comments (8)
@VorpalBlade Ah, thank you. I didn't realize the -d
flag existed. I only saw the top response with the -f
.
The tag is now updated.
Shall I close this?
from ahash.
The 0.8 releases are released from the 0.8-release branch. The master branch has some unreleased changes, that will be included in future releases. Those are the only differences I am aware of.
from ahash.
Hm, I checked out the tag v0.8.11 and compared that to the version from crates.io. They didn't quite match, and it seems like the tag simply points to an older commit (from before 0.8.10 was changed to 0.8.11).
from ahash.
I think using commit db36e4c clears the issue:
git clone https://github.com/tkaitchuck/aHash.git
cd aHash
git checkout db36e4c4f0606b786bc617eefaffbe4ae9100762 # current last commit from release-0.8 branch
cargo publish --no-verify --dry-run --package ahash
cd ..
cp aHash/target/package/ahash-0.8.11.crate our-release.tar.gz
curl -o upstream.tar.gz --fail "https://static.crates.io/crates/ahash/ahash-0.8.11.crate"
mkdir our-release
mkdir upstream
tar -xvzf our-release.tar.gz -C our-release
tar -xvzf upstream.tar.gz -C upstream
diff -r our-release upstream
from ahash.
Ok, it looks like I just tagged the last PR in the release as opposed to the PR with the version bump. That's is an issue in that if the tag is checked out it will list the wrong version in the toml. (I don't know if / when that is relevant) But it looks like the only way to fix that is a force push, which I am reluctant to do as it rewrites history.
from ahash.
Would it not be possible to just repoint the tag to a different version? Tags can be moved. You don't need to force push actual commits (which I agree would be bad). Or is the issue that the correct commit would be on a PR branch, not the actual repo history? And it was e.g. rebased or such.
https://stackoverflow.com/questions/8044583/how-can-i-move-a-tag-on-a-git-branch-to-a-different-commit comes up when searching for this (I admit I didn't know, I normally use SmartGit as a GUI for git when doing "scary" operations, as I find it is much more obvious what exactly I'm doing.)
from ahash.
@tkaitchuck just turned off my computer for the evening (writing this on my phone), so I won't be able to provide feedback on this until after work tomorrow.
from ahash.
This seems to be fixed now. Thank you very much.
from ahash.
Related Issues (20)
- test failure on s390x. HOT 1
- Significant performance regression from 0.8.6 to 0.8.7 HOT 11
- compile error: use of unstable library feature 'stdsimd' HOT 20
- feature request: ahash without length prefixing HOT 3
- Deterministic hash value HOT 2
- error[E0635]: unknown feature `stdsimd` HOT 19
- Significant bump in MSRV from 0.8.7 to 0.8.8 HOT 9
- No link to crates.io HOT 1
- RandomState has too many collisions in low order bits when hashing a u64 HOT 29
- Hashing `&T` yields different results compared to `T`
- Fragile build script: crate automatically enables "specialize" feature HOT 14
- ahash 0.8.11 breaks hashbrown? HOT 6
- Work around `swap_bytes` on WebAssembly HOT 1
- git source unaligned with crates.io release HOT 5
- Linking Errors with Specific Optimization Levels When Running Test Cases HOT 1
- rust v1.78 std simd feature removed HOT 1
- `set_random_source` never returns `Err(false)`
- Replace atomic-polyfill with portable-atomic
- Suggestion: Alternative wrapper HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ahash.