tkomstadius / bruse Goto Github PK

When trying to open a path containing # in FileLoader, it doesn't work as intended. This is probably because the # gets ignored since it's considered an anchor link.

Encoding the url should probably solve this.

For example GET /service/3/files/browse.json?path=/folder/mapp/#wierdfolder, gives us the contents of /folder/mapp/, without /#wierdfolder.

Choosing a couple of files, importing them and then adding specific tags to them is not working. Adding general tags for all imported files is working though.

When a tag ends on a comma and the user presses any of the breaking keys, it creates an empty tag.

If the system is installed without for example Dropbox, the site crashes since the links to providers are hard coded into the site. A loop/if to catch these failures so that the system can be installed with the providers the user wants to host.

These bad boys are causing the problem:
<%= link_to 'Sign in with Dropbox', user_omniauth_authorize_path('dropbox_oauth2') %>

This leads to a weird behaviour for the user. Use link instead of foreign_ref for the links!

Downloading a file from Google Drive destroys that file. For example, downloading a pdf file through Bruse makes it impossible to open that pdf locally.

Instead, it gets downloaded as a text file containing

#<Google::APIClient::Result:0x007ffe08466370>

The same files are loaded over and over when the user clicks "Load more" at the bottom

When running test in the feature/modular-filehandling branch, a deprecation warning is thrown:

Run options: --seed 49147

# Running:

.......................DEPRECATION WARNING: You are passing an instance of ActiveRecord::Base to `find`. Please pass the id of the object by calling `.id`. (called from current_user at /Users/kalas/Dropbox/DEV/bruse/app/controllers/application_controller.rb:12)
...No results found
.

Fabulous run in 7.438363s, 3.6298 runs/s, 7.2597 assertions/s.

27 runs, 54 assertions, 0 failures, 0 errors, 0 skips

The warning is not thrown in develop. Diff of Gemfile.lock (command: git diff feature/modular-filehandling develop -- Gemfile.lock) between the two files looks like this:

diff --git a/Gemfile.lock b/Gemfile.lock
index e86aa66..d1b14bf 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -37,8 +37,6 @@ GEM
       activemodel (= 4.2.0)
       activesupport (= 4.2.0)
       arel (~> 6.0)
-    activerecord-import (0.4.1)
-      activerecord (>= 3.0)
     activesupport (4.2.0)
       i18n (~> 0.7)
       json (~> 1.7, >= 1.7.7)
@@ -154,7 +152,6 @@ GEM
     multipart-post (2.0.0)
     nokogiri (1.6.6.2)
       mini_portile (~> 0.6.0)
-    normalize-rails (3.0.1)
     nprogress-rails (0.1.6.6)
     oauth2 (1.0.0)
       faraday (>= 0.8, < 0.10)
@@ -211,7 +208,6 @@ GEM
       thor (>= 0.18.1, < 2.0)
     rake (10.4.2)
     rdoc (4.2.0)
-      json (~> 1.4)
     sass (3.4.13)
     sass-rails (5.0.1)
       railties (>= 4.0.0, < 5.0)
@@ -266,7 +262,6 @@ PLATFORMS
   ruby

 DEPENDENCIES
-  activerecord-import (~> 0.4.0)
   angularjs-rails
   better_errors
   bourbon
@@ -288,7 +283,6 @@ DEPENDENCIES
   letter_opener
   lodash-rails
   minitest-rails-capybara
-  normalize-rails
   nprogress-rails
   omniauth
   omniauth-dropbox-oauth2

Does anyone have and idea of what's going on?