tlberglund / ratpack Goto Github PK

When type is application/json, it would be nice if Ratpack would allow direct posting of the JSON data including auto-deserialization using JsonSlurper.

Since Ratpack now has some tests, we should be running them when the project changes. Set up a build in TravisCI for great justice.

It appears 'params' and 'urlparams' are not thread safe.

If a second request comes into a request handler while the previous one is still processing, the value of 'params' and 'urlparams' are replaced in the namespace of the original request.

To see this in action, run the following Ratpack application and hit the method concurrently from two different web browsers.

get('/testing') {

    def number = (new Random()).nextLong()

    println "Start " + Thread.currentThread().getId() + ' == ' + params.value

    Thread.sleep(2000)

    println "End " + Thread.currentThread().getId() + ' == ' + params.value

    return "Value: " + params.value + ' - ' + number

}

in Firefox goto http://localhost:5000/testing?value=Firefox
in Chrome goto http://localhost:5000/testing?value=Chrome

Refresh both pages quickly, and you'll find it returns the query string parameter from the second request in both browsers.