tldraw / core

Renderer for tldraw and maybe you, too.

@tldraw/core

This package has moved to the tldraw/tldraw monorepo.

core's Issues

Testing Approach

Need some of your thoughts on how you want to approach writing tests.

• Only render component test is fine or
• Looking for some detailed unit tests validating attributes
  There are multiple point of view.

Example

describe('binding', () => {
  test('mounts component without crashing', () => {
    render(<Binding point={[0, 0]} type={'anchor'} />)
  })
  test('validate attributes rendered properly for anchor binding type', () => {
    const { container } = render(<Binding point={[10, 20]} type={'anchor'} />)
    const use = container.querySelector('use')
    expect(use?.getAttribute('href')).toBe('#cross')
    expect(use?.getAttribute('x')).toBe('10')
    expect(use?.getAttribute('y')).toBe('20')
  })
}

container & dom query selection is not regarded as best practice in RTL. Only benefit to this approach, there is no need to change Binding component src code.

You can suggest which query selector you prefer. Based on that we may need to update actual component.

Created few simple test locally, not able to push to core remote branch. Initially planning to write small tests & small commit to get your review comments, so that I can align to your coding styles & approaches.