toberocat / guiengine

A powerful GUI Framework, allowing Server Owners and Developers to Craft Interactive Custom GUIs

Hi 👋, I'm Tobias

Dev from Austria

Languages and Tools:

 

guiengine's Issues

Bug: Sign don't work when editing

Description

When placing signs the edit UI doesn't show and NBT copied signs are blank. Braking them shows this error.

Steps to reproduce

1. Place sign
2. Brake sign

Logs

error.txt

Versions

Plugin: 1.4.2
Server: Paper 1.20.1 build 196

PlaceHolders in Lore

Hi

For some reason whenever I place a placeholder inside of a lore, the whole lor disappears from the material/item.
Is there another way to place them or is it just missing?

Add better invaild GUi error handling

Description

Currently when making a GUI and it has an issue (currently tested with Improved Factions ones), I get a big not useful java error. What It should show is the file location including name and line number it has an issue with parsing

Steps to reproduce

None

Logs

None

Versions

Server: Paper 1.20.1 build 108
GUI engine: 1.2.3

Lost on-click function after edit

In this component:

<component type="item" id="green-button" x="3" y="2" material="GREEN_TERRACOTTA" name="§aGreen button">
    <lore>§7Click me</lore>
    <lore>§7I promise §ait's worth§7 it</lore>
    <on-click type="edit" target="green-button" attribute="name" set-value="§eYou clicked me :)"/>
    <on-click type="edit" target="green-button" attribute="material" set-value="YELLOW_TERRACOTTA"/>
</component>

After clicked once, the GREEN_TERRACOTTA replaced by YELLOW_TERRACOTTA, and the name changed
And then, if I continue to click, it will cause error:

[22:06:10 ERROR]: Could not pass event InventoryClickEvent to GuiEngine v1.2.1
java.lang.NullPointerException: Cannot invoke "io.github.toberocat.guiengine.function.GuiFunction.call(io.github.toberocat.guiengine.GuiEngineApi, io.github.toberocat.guiengine.context.GuiContext)" because "function" is null

I found that in DefaultInterpreter.java , after convertValue() method, the on-click will filled with null

Single line of lore does not displayed

I was following the User Beginner Guide and I found when I add single lore to a item, it does not displayed

I found that ParserContext.getOptionalStringArray() used foreach to process the lore array, but when there have only one lore, the getOptionalNode() returned JsonNode is String instead of Array

How to use the PagedComponent

Is this code correct?

<gui title="§eTag" width="9" height="2">
    <component type="item" material="IRON_BLOCK" name="§eBack">
        <on-click type="action">[container:previous]</on-click>
    </component>
    <component type="item" x="8" material="DIAMOND_BLOCK" name="§eNext">
        <on-click type="action">[container:next]</on-click>
    </component>
    <component type="paged" id="container" y="1" width="9" height="1" interactions="true"
            pattern="0,1,2,3,4,5,6,7,8">
        <fill-empty type="item" material="GLASS_PANE">
            <on-click type="action">[message] Nothing here</on-click>
        </fill-empty>
        <page>
            <component type="item" x="1" material="EMERALD_BLOCK" name="§ePage 1">
                <on-click type="action">[message] Page 1</on-click>
            </component>
        </page>
        <page>
            <component type="item" x="7" material="REDSTONE_BLOCK" name="§ePage 2">
                <on-click type="action">[message] Page 2</on-click>
            </component>
        </page>
    </component>
</gui>