tobiasbielefeld / simple-solitaire Goto Github PK

When I perform this sequence of events, the scroll view on screen goes back to the top:

1. Click on Settings
2. Click on About Game
3. Click on:
   a. License
   b. Changelog
4. Scroll Down
5. Orientation Change

Since i updated from 3.9.2 to 3.10.1 Klondike (and maybe the other games too) sometimes shows only one black card and isn't usable. After erasing the app data in the android settings it works fine for some time.
Android is 6.0

I played several klondike games yesterday and today. The date of the scores shows today's date only

Hi there !

I've been using your app for some time now, and I really enjoy it, thanks! Mostly, I'm discovering new solitaires with your included rules. The only issue I have is that I need 7 clicks to go from a solitaire to its rules (back to home screen, into the manual, games rules, and finally click on the right rule). This is painful. Could a shortcut to a game's rules be included straight in the playing screen, please?

Many thanks!
Adrien

• option to hide the in game menu
• option to deactivate the auto complete button for each game individually
• show the number of steps made in a game
• make fullscreen possible on a galaxy s8+

Please display in statistics window total number of games and percentage of wins.

after moving a pile of 4 cards with a king on top from right-most to empty left-most the jack animated back to the right on top of the newly visible king there.

it stayed there even when i moved and removed cards there.

it animated back to the left when i put cards on the left-most pile.

Hello Tobias,

Thank you for creating this pleasant distraction! It's nice to play something more than just solitaire after so many years. The layout of the game looks neat, too.

I have noticed, that in Forty&Eight it is not always possible to move several cards in a correct sequence at once, even though the game rules allow it and there are free places in the foundation. Randomly, I can only move the lower two or three cards in a consecutive row of four or five and I am unable to tell what influences it.

You may want to check into that.

Good luck developing!

Mas

Hi and thanks for this new grate game in fdroid!,

it reminsds me realy much at kPatience (same end animation and card art). I like the handling very much. but there is one thing i am missing: i have seen that the app woekes geate in portrait and in landscape mode, but normaly my device is fixed to portrait mode so that i have to switch to landscape orientation if i want to enyoj the app best. So i would be very happy if you could add an orientation setting where you can select defaulr (as of the android system suggests), fixed landscape, fixed portrait ans landscape upside down mode. thanks in advance. and also i am happy to see more Patience's (like frecell, spider and yukon) in the future.

thanks and keep up the good work

Is it possible that you can please add a way to tap once on a card and then move it by taping on the place where the card should be moved to like the way other apps handle this?

Thanks!

Mar 29 '17 commit has compile error in activity_game_manager.xml Error:(21, 33) No resource found that matches the given name (at 'background' with value '@drawable/card_highlight').

Since may, I cannot get anywhere in the score board. Is the pointing system changed?

Hi! Thanks for the great games. Some games would be a lot easier with a 4-color deck, just like poker (clubs are green and diamonds are blue). Is this something that could be implemented?

Steps to reproduce:

1. Start a game of Spider (others will probably work too)
2. Tap Menu -> Start new game. An animation will begin, with the cards on the table stacks moving to the main stack
3. Quickly, before this animation ends and the animation of dealing cards from the main stack back to the tableau begins, tap Home (circle) button.
4. Tap Recent apps (square) button and close (swipe right or left) Simple Solitaire Collection
5. Open the application again.

After that, the game should be in a broken state, where the tableau is empty, there is only one pack in the main stack, which however can be dealt repeatedly until you run out of cards, at which point an exception is raised.

i can't install this app manually by downloading apk from play store. it says that there is an error while analyzing.
android 5.1

I have no other way of contacting you, so I opened an Issue. Thank you for the updates of late, with bug fixes. I really appreciate the time you find to maintain this app and listing it on F-Droid. I use it daily. Feel free to close this Issue after reading this.

Currently, it looks like the number of undoable moves is fixed to 20. I think it would be nice if this number were configurable (with perhaps 20 still being the default value).

Thanks

Hey! Love the game. However I've noticed there's an issue when restarting the game, or returning to the main menu.

Often when tapping: Menu > Start new game OR: Menu > Return to main menu, the Menu window disappears and nothing happens!

As of a couple of releases ago, I've noticed that Spider will often not end the game when the last tableau stack is merged and moved to the foundation stacks, and you're left with an empty tableau and no way to end the game.

Hitting undo and redoing the last move a few times (or splitting the last merge into a couple of additional moves) seems to eventually cause the game to end properly, which makes me think it's something timing-related?

I mostly play Spider and Klondike; I don't see this behavior with Klondike, but I usually auto-complete Klondike (which isn't an option with Spider), so perhaps it's related?

FWIW, I'm using the F-Droid build, on a Nexus 5 running android 7.1.1 (cyanogenmod).

I am unable to flip the deck after a tapping my way through it on my Nexus 7 Flo. It works on my Moto X Play Lux. Both with draw 1 or 3.

Or at least it should be possible to override the setting on a per-game basis. If you happen to alternate between playing a game with 2-color deck and another with 4-color deck, every time you switch you have to change the global setting first.

When the starting position includes kings already on the bottom of their stack, it is impossible to get the 20 points bonus that comes from moving that king to a free space, since the king is already on a free space. Thus the total score at the end of the game (not counting time bonus) cannot reach the expected 3200.

On my SGS3 the Klondike game is very small. Only while in portrait, landscape is fine.

Looking thru the commits it does seem like you changed some things there, figured I'd let you know.

Please allow moving multiple cards in the game Fourty&Eight if free tableau fields are available - similar feature is already available for FreeCell.

Maybe even remove option to disable that behaviour in FreeCell, because it doesn't affects rules of gameplay in any way.

I've been playing your solitaire game for quite a while, usually Klondike, and I've come to notice an issue with card distribution. Way too many times, cards are grouped on the stack, in a non-random order. For example, cycling through the stack one card at a time, I'll commonly get a BK, RQ, BJ, R10, etc.. in order. This occurs from the main stack as well as on the lower stacks when turning them over. Looking into it (I'm not at a place I can compile and test changes myself), it appears that the randomize(Card[] array) function isn't using any kind of seed when randomizing cards. I realize it's a PRNG, but when receiving things like 4 aces on initial deal, or cards in order for use, it takes away enjoyment from the game. I really do like it, but sometimes I can nearly clear the board before flipping my first card to the discard stack.

The number of cards that can be moved seems a bit low. I've done a bit of thinking and came up with the following formula:

x = (c+1)*(1<<t); // 1<<t == pow(2,t)

Where c is the number of free cells, and t is the number of free tableau places. Please double check this.
Would you implement this as well please?

Wouldn't it be good to have date stamp in high score board?

I am trying to implement Google+ and Facebook authentication and gamification with friends in a fork of your project, any tips help will be appreciated. Great work btw, one of the best solitaire open sources I have come across till date.

Hi,

i have found a small Bug on High Scores Page. Somehow i managed to get a win rate greater than 100%. As i started the Game today i had a win rate of 100 % and 10 of 10 games won. After i played another Game i had a win rate of 110% and 11 of 10 games won.

I managed to capture a Screenshot at the time i firstly noticed the issue.
IMGUR

The Version i play is 3.3.5, compiled on 04.03.2017 from FDroid.

If you need some more information, feel free to ask for it.

I'd quite like an option to disable the score penalty from hitting undo. I understand it makes sense for games like Klondike where undo can be used to know about the face-down cards, which is kinda cheating, but in FreeCell for example, undo does not change much.

I'm left handed, and it would be more practical for me to tap on the cards if they are of the left of the screen. Not only for me, but for the disabled people too, who play with only one hand. Playing with the left hand makes us hide the entire screen with our hand.

Maybe a option could switch the hidden cards from the right to the left.

When for example in Pyramid, say two 4 lie next to each other and you move a 9 to them, and if your aiming is bad so you touch both 4, both of them will vanish.
I don't know much about the other games, just playing the ones I know 😀, but I think it would be in any game where you have to move one card to another.
Although I don't have any experience with Android programming, I think you will have to calculate how much of one card lies on the other one and just remove the card with the higher part.

You may answer in English or German ☺️

Under Settings > Games, the settings for "Number of cards to draw" show the wrong labels. They should be "Draw 1" and "Draw 3", but instead both choices say "Draw 1". This applies to Canfield, Klondike, and Vegas. Note that the choices do seem to toggle between 1 and 3 cards, so the setting does work. You just have to guess which one is for three.

Version 3.2, when I double tapped the ace, it has been moved against the rules into discard stack.

I just read into the README that you are trying to legally use icons from Kpatience. I just downloaded Aisleriot and saw that it has a quite nice selection of card themes.

Checking into their source, it seems that most of the card themes are in public domain. If you are interested in adding them, here is the link to the resources: https://git.gnome.org/browse/aisleriot/tree/cards.

Firstly, thank you for this collection! I find it tremendously addictive! I would love this even more if an implementation of Napoleon's Tomb could be added. Having looked over the Klondike implementation, it looks like Napoleon's Tomb would be pretty simple to implement if you were familiar with the code. Unfortunately, I've got little free time to become familiar and open a PR.

The ruleset for this game can be found at: http://www.pahnation.com/how-to-play-napoleons-tomb

If there's anything else I can do to better describe the game, please let me know. If I happen to fund some free time, I may look at implementing this and issue a pull request, but I wanted to request here to see if this interested anyone else! Thanks!

Occasionally score is increased after game is won. This happens, at least, with Mod3 and Golf.

Example from Mod3:

1. One move left to win the game, score is 4550.
2. The final move is done, score is increased to 4600.
3. Right away score is increased to 13797.
4. Menu pops up.

The increased score is save to high scores.

I think I noticed a bug in "Vegas": If you have seen all cards of the main deck (top right), it is seems impossible to turn the deck back. Tapping on the "circular double arrow" logo has no effect, in contrast to what is described in the manual, and unlike in "Klondike" for example. The game itself is not frozen, the other cards are moveable. Can you reproduce this?

Empty fields in Canfield shows "A", but in most cases you cannot put aces on them. Maybe the icon should correspond to the true card which can be placed on it?

When moving an ace from one base to another, the score is increased by 45.

Please add option for change language of the game, instead of depending on system language. It will be useful for selecting languages which are not selectable in Android, for example Esperanto (I can provide translation).

Why some strings like "Open navigation drawer" or "Menu" are marked as non-translateable?

Nice project. The bottom bar looks a bit old-shool.
What do you think about changing the activity more to a material design?
The bar could be on the top and display Material Design Icons. So the overall-feeling would be more modern and well-known by the user.

Regards

Thus, it is purely personal taste, but a couple of icons would see the best of current, for example:
Score -> https://materialdesignicons.com/icon/trophy-award
Hint -> https://materialdesignicons.com/icon/lightbulb-on

:)

Hi @TobiasBielefeld

I found this app on the Google Play Store. This guy just took your source code and put it on the Store, without warning this is free/libre software...

As you are the owner of the source code, feel free to open a request to google here to remove this false app from the Store, if it's your wish ;)

Don't forget to tell Google that:

• The app is licensed under GNU GPL v3 license and this guy is violating it;
• He is falsely claiming he made the app.

Maybe add a link to this repo in the request, some screenshots of your original app...

Someone on Google Play wants new games:

1. Indian Rummy 2. Thousand card game (1000) 3. Bluff card game (420) 4. Hearts

So I put this here, to not forget it

I don't know whether this happens with other games, but I certainly saw it in Simple Simon. In my experience, between about 1/5 and 1/6 of the generated Simple Simon games are unsolvable. This forces the user to "start new game" and a lost game is recorded in the stats.

I understand that a complete check could be very heavyweight, but I'd appreciate at least some basic checks, starting from the obvious base case where no move is possible from the very beginning - yes it happens - and perhaps checking that after 1, 2, ...N moves (for small values of N, otherwise the possibilities explode) the game doesn't reach an unsolvable state. That would already be a step forward.

Another option could be to modify the board generation algorithm to ensure it generates solvable games (perhaps starting from a solved game, then scrambling the cards "backwards" so we're sure that the initial state that is presented to the user can lead to a solved game).

Thanks

While playing Vegas I observed, that from the point where all highscores are at maximum points, the highscores are no longer updated (even if, for instance, the game is completed in less time).

My guess is that master/app/src/main/java/de/tobiasbielefeld/solitaire/helper/Scores.java should be:

/**
 * Adds a new high score to the list. New score will be inserted at the last position
 * and moved left until it is in the right position
 */
public void addNewHighScore() {
    /* ... */

    //if the new score is greater than the last saved one or the last one is empty, override it
    /*  Should this rather be "score >= savedScores[index][0]" ? */
    if (score > savedScores[index][0] || savedScores[index][0] == 0) {
        /* ... */
    }
}

The part for inserting the new highscore seems correct, as - as far as I can tell - the time is included in the sorting.

When moving an Ace to the foundation, score will be increased, however it will also increase if the Ace was moved from foundation to foundation. That way, score can be increased indefinetly by just moving around one Ace within the foundation.

My guess is that something is wrong in Simple-Solitaire/app/src/main/java/de/tobiasbielefeld/solitaire/games/Vegas.java:

public int addPointsToScore(ArrayList<Card> cards, int[] originIDs, int[] destinationIDs, boolean isUndoMovement) {
        int originID = originIDs[0];
        int destinationID = destinationIDs[0];

        if (destinationID >= 7 && destinationID <= 10){ /* <= should check originID as well */
            return betAmount/10;
        }

        if (originID >= 7 && originID <= 10){
            return -2*betAmount/10;
        }

        return 0;
}

When moving an ordered stack that starts with a king between spaces on the tableau using the automove feature, if the stack has more than just the king the bonus for moving that king to an empty space will be added even though it shouldn't. This makes it possible to get an arbitrary large score by moving stacks around.
I think the problem comes from this check: stacks[originIDs[0]].getSize() != 1 at https://github.com/TobiasBielefeld/Simple-Solitaire/blob/master/app/src/main/java/de/tobiasbielefeld/solitaire/games/Freecell.java#L271 . I believe the appropriate check would take into account the size of the stack being moved, i.e. something like stacks[originIDs[0]].getSize() - cards.size() > 0.

Please consider making FreeCell offer autocomplete sooner. It seems to me the cards in the stacks only need to be in ascending (or equal) order. The suits don't really matter.