GithubHelp home page GithubHelp logo

tobiasrohloff / nestedscrollwebview Goto Github PK

View Code? Open in Web Editor NEW
334.0 334.0 81.0 73 KB

An Android WebView that implements NestedScrollingChild, in order to use it with CoordinatorLayout and AppBarLayout.

License: Other

Java 100.00%

nestedscrollwebview's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

nestedscrollwebview's Issues

Failed to sync Gradle project

Hello, I was excited to see that you provided a gradle compile statement. I tried using the command, compile 'com.github.rhlff:NestedScrollWebView:v1.0.2' ... but i keep getting the error "Could not find com.github.rhlff:NestedScrollWebView:v1.0.2" Is there a different command I should be using?

Thanks,

Unable to import package.

implementation 'com.github.rhlff:NestedScrollWebView:v1.1.1' in maven repo definition

vs

package com.tobiasrohloff.view; in library.

This way I was unable to import the package after adding the above implementation to my dependency list. This worked before cbb0a83

Note that neither import package com.tobiasrohloff.view; nor import com.github.rhlff:NestedScrollWebView, nor import com.github.tobiasrohloff.NestedScrollWebView works.

Multitouch is broken

Multitouch doesn't work within NestedScrollWebView.
We need to stop scrolling when second touch is active. I found this way to fix it:

case MotionEvent.ACTION_POINTER_DOWN: // added to fix multitouch
case MotionEvent.ACTION_UP:
case MotionEvent.ACTION_CANCEL:
        stopNestedScroll();
        result = super.onTouchEvent(event);
        break;

Bouncy scrolling in BottomSheetDialogFragment

Hi, I tried using this library in a BottomSheetDialogFragment, and it worked pretty well, apart from the bouncy scrolling when settling the BottomSheet by dragging the finger. Does anyone have an idea of the cause of this issue? Also, sometimes, the WebView scrolls up while dragging the bottom sheet from expanded to peek state.

Doesn't work well with CollapsingToolbarLayout

hello !

when NestedScrollingParent consume all motion event (AppBarLayout is still show) , the scrolling state is shake .

actually when NestedScrollingParent is scrolling NestedScrollWebView is also have small reciprocate move , because result = super.onTouchEvent(trackedEvent) is aways exe even deltaY == 0.

you can set AppBarLayout height bigger to get this performance

No (visible) scroll bar

Hi,
thanks for your project. I just replaced my old vanilla WebView with NestedScrollWebView and while everything else seems fine, there is one difference:
NestedScrollWebView has no scroll bar on the right side. Are you seeing this on your end too?

Thanks
Kai

`onTouchEvent` does not handle `MotionEvent.ACTION_POINTER_UP`

When I zoom a WebView by pinching, zooming will suddenly be canceled.
It seems that onTouchEvent does not handle MotionEvent.ACTION_POINTER_UP.
I added case MotionEvent.ACTION_POINTER_UP at L109 (or changed L108 - L110 to default:),
and it works fine.
Could you confirm this?

Failed to resolve: com.github.rhlff:NestedScrollWebView:v1.0.2

Hi there,

I just started working on this project for a new client and they are using the NestedScrollWebView.
My gradle can't find your dependency on jitpack. Did you removed it from Jitpack?

project level build.gradle

allprojects { 
    repositories {
        google()
        jcenter()
        maven { url 'https://jitpack.io' }
        maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
        flatDir {
            dirs "../libs"
        }
    }
}

app level build.project
implementation 'com.github.rhlff:NestedScrollWebView:v1.0.2'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.