Question on new C# port about ua-parser

[galmeida]

@enemaerke

1. Java port is broken, the guy who first wrote the c# implementation did almost a literal translation from java, so it's broken too, I've fixed the java code in my local repo based on the php port. But @tobie said "We're moving away from the is_mobile booleans.", so I didn't mind to PR it. see #112
2. look #111 and #110

[tobie]

1: I've included unit tests of the yaml-defined testcases under test_resources
but I get one failing test on matching the useragent 'Mozilla/5.0 (BlackBerry;
U; BlackBerry 9320; en-GB) AppleWebKit/534.11+ (KHTML, like Gecko)
Version/7.1.0.398 Mobile Safari/534.11+' as a mobile device. From running the
java tests I see they have the same issue (seems the issue, at least for me
and for the java version, is that the list of mobile OS'es are matched exactly
against the family and BlackBerry 9320 != BlackBerry so the device is not
marked as mobile). Is this a known issue or is it just c#/java that suffer
from this?

We should remove this data from the test files. Tracking in #114.

2: I've added some Apache2 copyright and my name to the readme.

Please keep comments related to the pull request in the relevant issue. If this is a fork from the initial C# submission, please make sure the original author is credited.

I'd like to
support this going forward but how can I contribute and stay in the loop for
updates/fixes across the ported platforms?

Not sure what you mean. GitHub notifications should allow you to follow along. Else the regexes file should update itself.

3: As far as I can tell there is no Travis-CI support for C# which is too bad
since I'd like to integrate into some CI system. Any requirements/thoughts/
ideas on this from more experienced githubbers?

Nope. Sorry. Also, we'd need to split each language into a different project to allow for multiple language CI.

4: I think @tobie has touched on this but c# is really not all that happy with
_ (illegal escape) so I am currently just working around that and can remove
this if the regex'es are adjusted (not really a question come to think of it,
more of a reminder)

Pending PR in #111.

[tobie]

@enemaerke FYI, I fixed the regexp problem, so you no longer have to special case your implementation.