toddwschneider / ballr Goto Github PK

Can you expose a shiny field that lets users input a specific value for GameID

This would give the shot data for a specific game

Looks like you just have to pass the shiny side user value into the api request

http://stats.nba.com/stats/shotchartdetail

a gameid specific shot chart is related to (but seems easier than) the request below
#1

I think I may have found an issue with your charts. I was comparing the data to a few other shot chart sites, and it looks like your data is flipped. The links below illustrate the issue. A good example is Lamarcus Aldridge's 2018-2019 shot chart. He’s pretty known to setup on the left block (if you’re facing the basket) but on your charts, his main shots are on the right side of the court.

I tried to compare it to a few different web apps that did shot charts, not just Stat Muse, so I included Steph Curry’s 2015-2016 chart with links to other’s

Lamarcus Aldridge's 2018-2019 shot chart
https://www.statmuse.com/ask?q=lamarcus+aldridge+2018-2019+shot+chart&d=nba

Steph Curry 2015-2016 shot chart
https://www.statmuse.com/ask?q=stephen+curry+2015-2016+shot+chart&d=nba
http://buckets.peterbeshai.com/app/#/playerView/201939_2015?playerSelector=true&dataType=zones
http://www.austinclemens.com/shotcharts/#players

If you’ll look at Steph’s 3’s to the right side (not corners) you’ll see he’s a bit worse than other areas of the court. On your chart, it’s flipped to the other side.

I think that your tool is better than all of these, and I hope you can correct the issue. I could totally be wrong, but I’ve been looking at a bunch of different ones, and they all look flipped to me. Thanks for your consideration.

When running the runGitHub command, I get the message in my window that say ERROR: 'data' must be of a vector type, was 'NULL'.

Attaching package: ‘dplyr’

The following objects are masked from ‘package:stats’:

filter, lag

The following objects are masked from ‘package:base’:

intersect, setdiff, setequal, union

Attaching package: ‘jsonlite’

The following object is masked from ‘package:shiny’:

validate

Warning: Error in matrix: 'data' must be of a vector type, was 'NULL'
57: matrix
53: fetch_shots_by_player_id_and_season [fetch_shots.R#70]

Above is what my code shows before the window pops open and shows the error statement.

Hi,

First of all, congratulation on this fantastic work. I honestly believe the pros at NBA are going to check these charts out quite a bit. You can get a lot of information out of them, and very intuitively so.

Have you considered allowing users to not filter by season, therefore getting stats for a player's entire career? I'm sure many would like to see that. I think you can take that a step further and do charts that compare a player's performance against his own, across his career, highlighting good and bad years. It should allow us to see when a player peaked and compare his performance across different teams.

Anyway, keep up the good work!

When running the live version of this application, it throws a "ERROR: 'data' must be of a vector type, was 'NULL'" error

Hi, I attempted to run the code for creating shot charts but all I am getting is a blank window. There doesn't seem to be any error messages to help. When I hit "Stop" I get the following:

Warning: Error in curl::curl_fetch_memory: Operation was aborted by an application callback
59: curl::curl_fetch_memory
58: request_fetch.write_memory
56: request_perform
55: GET

Can you help? Thanks