toefungi / exchange-rates-as-promised Goto Github PK

Hi, I was searching for an exchange rate library, found yours and tried it out. But it seems this library is not meant to be used via NPM. My project is in typescript, but when I try to import { ExchangeRate, Currencies, ExchangeResponse } from 'exchange-rates-as-promised'; it doesn't find the module. Also your readme was written like it was meant to be used not from node_modules, but directly by using the source folder.

I haven't done NPM modules, so I'm not sure what you would need to do to make it work, but here's what I did to make it work:

1. I ran npm add exchange-rates-as-promised, and installed the package in the node_modules.
2. I went to folder node_modules/exchange-rates-as-promised and ran npm install and npm run build to build the index.js file into build directory.
3. I edited your package.json and changed main to point to build/index.js.

After those operations the module was found, and typing support was enabled also in VSCode, and I was able to use your package :)

I hope you can update this and make it easier to use. It's a very handy package!

Hi,

I just updated your package from v1.0.4 -> v1.0.10, but now when I try to create a new ExchangeRate object, it throws the following exception:
TypeError: exchange_rates_as_promised_1.ExchangeRate is not a constructor

I'm using it like this:

import { ExchangeRate, Currencies } from 'exchange-rates-as-promised';
const exchangeRate = new ExchangeRate();
...

Same code worked on 1.0.4. Based on your docs or commit history, I didn't see any changes on how it should be used, so I suspect the issue is with the NPM package you create.