Comments (2)
I completely agree with you about the Option
.
However, I'm not sure about the Result
: how do we handle the Err
variant if the std
feature is disabled?
from valuable.
I agree that Option
's should almost certainly flatten the value. I'm less convinced about Result
--- if the Err
side of a Result
is not a &(dyn std::error::Err + 'static)
, there's no way for the visitor to know if the value is an Ok
or an Err
.
As a (somewhat contrived) example, if I recorded a Result<usize, usize>
, the visitor would totally lose the information of whether the Result
was an Ok
or an Err
...which may actually be the only information that we actually want to record.
IMO, Result
s should be Enumerable
, so that the information of whether it was Ok
or Err
is always retained. But, I could probably be convinced otherwise by a sufficiently good argument...
from valuable.
Related Issues (20)
- `NamedValues::get` footgun.
- Feature request: Expose doc comments for struct/enum/field definitions HOT 1
- Feature request: Allow reading structable attributes
- the trait `tracing::Value` is not implemented for `valuable::Value<'_> HOT 2
- question: is valuable expected to work with tracing macros? HOT 1
- Create a span for plugin init HOT 1
- Constructing objects from `Value`
- derive: implement #[valuable] attributes HOT 3
- Add a way to iterate on non-primitives/visit specific slices for Listable
- Visitor holding `Value` HOT 13
- Consider adding a concrete lifetime to the Visit trait HOT 1
- Consider changing Value::Error to &(dyn Error + 'static) HOT 1
- Owned [NamedField] for Fields HOT 10
- Consider Visit::visit_key + Visit::visit_value HOT 4
- Release initial version HOT 6
- publish `valuable-serde`
- `dyn Display` primitive value HOT 1
- How should we implement Valuable for Uuid? HOT 3
- Strange happenings with manual implementation of `Valuable` HOT 1
- Introduce a lifetime generic to `Visit` in order to allow borrowing out specific parts of the `valuable::Value` during visits HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valuable.