GithubHelp home page GithubHelp logo

Comments (2)

taiki-e avatar taiki-e commented on September 26, 2024

I completely agree with you about the Option.

However, I'm not sure about the Result: how do we handle the Err variant if the std feature is disabled?

from valuable.

hawkw avatar hawkw commented on September 26, 2024

I agree that Option's should almost certainly flatten the value. I'm less convinced about Result --- if the Err side of a Result is not a &(dyn std::error::Err + 'static), there's no way for the visitor to know if the value is an Ok or an Err.

As a (somewhat contrived) example, if I recorded a Result<usize, usize>, the visitor would totally lose the information of whether the Result was an Ok or an Err...which may actually be the only information that we actually want to record.

IMO, Results should be Enumerable, so that the information of whether it was Ok or Err is always retained. But, I could probably be convinced otherwise by a sufficiently good argument...

from valuable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.