GithubHelp home page GithubHelp logo

Comments (5)

KevinMGranger avatar KevinMGranger commented on September 26, 2024

I would find special-casing &[u8] (and Vec<u8>) useful in the library I'm working on.

Another (more general) idea is to do something akin to #[serde(with = "module")], allowing a customized Valuable impl on a per-field basis.

from valuable.

hawkw avatar hawkw commented on September 26, 2024

tracing 0.1 supports f64s as typed values; if we're going to do a wholesale replacement of tracing's value system with valuable in tracing 0.2, we should probably add support for floats as primitive values.

from valuable.

taiki-e avatar taiki-e commented on September 26, 2024

we should probably add support for floats as primitive values.

I believe floats are already supported.

/// A Rust `f32` value
///
/// # Examples
///
/// ```
/// use valuable::Value;
///
/// let v = Value::F32(3.1415);
/// ```
F32(f32),
/// A Rust `f64` value
///
/// # Examples
///
/// ```
/// use valuable::Value;
///
/// let v = Value::F64(3.1415);
/// ```
F64(f64),

from valuable.

hawkw avatar hawkw commented on September 26, 2024

we should probably add support for floats as primitive values.

I believe floats are already supported.

/// A Rust `f32` value
///
/// # Examples
///
/// ```
/// use valuable::Value;
///
/// let v = Value::F32(3.1415);
/// ```
F32(f32),
/// A Rust `f64` value
///
/// # Examples
///
/// ```
/// use valuable::Value;
///
/// let v = Value::F64(3.1415);
/// ```
F64(f64),

whoops, it looks like i can't read! never mind!

from valuable.

hawkw avatar hawkw commented on September 26, 2024

I don't think this needs to be a blocker for 0.1; we can always add new primitives in backwards-compatible changes.

from valuable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.