tom-anders / telescope-vim-bookmarks.nvim Goto Github PK

View Code? Open in Web Editor NEW

114.0 114.0 23.0 9 KB

Integrates vim-bookmarks into telescope.nvim

License: MIT License

Lua 100.00%

telescope-vim-bookmarks.nvim's People

Contributors

Stargazers

Watchers

telescope-vim-bookmarks.nvim's Issues

A config option for sorting by line number?

Hi! Is there a sorting strategy by line number in this plugin? An awesome tool!

Commands not working after recent telescope update

The usage commands from the README are broken, for example :Telescope vim_bookmarks all shows the error: Error executing Lua callback: ...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:45: attempt to call field 'get_default' (a nil value).

The commands were working but I think a recent update to Telescope may have affected something, so this is no longer working.

Live grep in bookmarked files

Hello 👋

Thanks for the awesome plugin. I was wondering if it is possible to telescope live grep in bookmarked files.

`E5108` : Telescope bookmarks not launching

My config

I installed plugin via Lazy:

-- plugins.lua
{
    "tom-anders/telescope-vim-bookmarks.nvim",
},

Error

I get the following error when executing :Telescope vim_bookmarks all

Error executing Lua callback: Vim:E117: Unknown function: bm#all_files                                                                                                                                                                                                          
stack traceback:                                                                                                                                                                                                                                                                
        [C]: in function 'bm#all_files'                                                                                                                                                                                                                                         
        ...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:142: in function <...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:141>                                                                                                                          
        ...share/nvim/lazy/telescope.nvim/lua/telescope/command.lua:183: in function 'run_command'                                                                                                                                                                              
        ...share/nvim/lazy/telescope.nvim/lua/telescope/command.lua:253: in function 'load_command'                                                                                                                                                                             
        ...ocal/share/nvim/lazy/telescope.nvim/plugin/telescope.lua:108: in function <...ocal/share/nvim/lazy/telescope.nvim/plugin/telescope.lua:107>

I get the following error when executing :Telescope vim_bookmarks current_file

Error executing Lua callback: Vim:E117: Unknown function: bm#all_lines                                                                                                                                                                                                          
stack traceback:                                                                                                                                                                                                                                                                
        [C]: in function 'bm#all_lines'                                                                                                                                                                                                                                         
        ...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:18: in function 'get_bookmarks'                                                                                                                                                                             
        ...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:99: in function 'make_finder'                                                                                                                                                                               
        ...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:112: in function 'make_bookmark_picker'                                                                                                                                                                     
        ...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:149: in function <...okmarks.nvim/lua/telescope/_extensions/vim_bookmarks.lua:145>                                                                                                                          
        ...share/nvim/lazy/telescope.nvim/lua/telescope/command.lua:183: in function 'run_command'                                                                                                                                                                              
        ...share/nvim/lazy/telescope.nvim/lua/telescope/command.lua:253: in function 'load_command'                                                                                                                                                                             
        ...ocal/share/nvim/lazy/telescope.nvim/plugin/telescope.lua:108: in function <...ocal/share/nvim/lazy/telescope.nvim/plugin/telescope.lua:107>

Error running :Telescope vim_bookmarks

I'm running "Telescope vim_bookmarks" and I get the following error in the status area:

E5108: Error executing lua ...re/nvim/plugged/telescope.nvim/lua/telescope/command.lua:100: attempt to call a nil value

I have updated all the plug-ins as of right now

telescope.nvim : 69eb5eacff421e05aeb1e02ff97ef64bfd955c53
telescope-vim-bookmarks.nvim : 4da66dab44f37d0de4b88cedf9e114c5b0855c20
vim-bookmarks: 3adeae10639edcba29ea80dafa1c58cf545cb80e

Delete action does not seem to work

Is the delete action still working as expected? With my lazy.nvim setup:

      {
        "MattesGroeger/vim-bookmarks",
        config = function()
          vim.g.bookmark_no_default_key_mappings = 1
          vim.g.bookmark_save_per_working_dir = 1
          vim.g.bookmark_sign = ""
          vim.keymap.set('n', '<Leader><Leader>', '<Plug>BookmarkToggle', { desc = "Bookmark toggle" })
          vim.keymap.set('n', '<Leader>bi', '<Plug>BookmarkAnnotate', { desc = "Bookmark annotate" })
          vim.keymap.set('n', '<Leader>bj', '<Plug>BookmarkNext', { desc = "Bookmark next" })
          vim.keymap.set('n', '<Leader>bk', '<Plug>BookmarkPrev', { desc = "Bookmark previous" })
        end,
      },
      "tom-anders/telescope-vim-bookmarks.nvim",
      {
        'nvim-telescope/telescope.nvim', version = '0.1.1',
        dependencies = { 'nvim-lua/plenary.nvim', "MattesGroeger/vim-bookmarks",  "tom-anders/telescope-vim-bookmarks.nvim"},
        config = function()
          local telescope = require('telescope')
          telescope.setup()
          -- vim_booksmarks
          telescope.load_extension('vim_bookmarks')
          vim.keymap.set('n', 'ba', telescope.extensions.vim_bookmarks.all, { desc = "Show [b]ookmarks in [a]ll files" })
          vim.keymap.set('n', 'bc', telescope.extensions.vim_bookmarks.current_file, { desc = "Show [b]ookmarks in [c]urrent file" })
          local bookmark_actions = require('telescope').extensions.vim_bookmarks.actions
          require('telescope').extensions.vim_bookmarks.all {
            attach_mappings = function(_, map)
              map('n', 'dd', bookmark_actions.delete_selected_or_at_cursor)

              return true
            end
          }
        end,
      },

Pressing dd in normal mode in Telescope does not have any action.

Abandoned?

Is this repo abandoned?

opts.hide_filename' is no longer valid. Please use 'opts.path_display

Running require('telescope').extensions.vim_bookmarks.current_file() (:Telescope vim_bookmarks current_file) shows this:

Hide: true
Deprecated window options. Please see ':help telescope.changelog?

'opts.hide_filename' is no longer valid. Please use 'opts.path_display? -instead. Please See ':help telescope.changelog-839'

Please add a default for "Telescope vim_bookmarks"

Please add a default option to "Telescope vim_bookmarks" and make it search starting from the current directory down, recursively.

Alternatively, make the default option configurable, with the most sensible options be:

from current directory down
inside "this project" directory, where project is found by navigating up to the ".git", ".svn" ... - I believe there are already plug-ins for finding the project root.

I typically launch all my editor windows from the top of the tree so this would not make much of a difference to me, but maybe some users prefer to cd several layers deep.

Thank you!

Option to display annotation AND line

How see complete path with vim_bookmarks.all()

Sale to all, I work on several projects and I would like to view the bookmarks file for all its path. I tried to edit like this

M.custom_vim_bookmarks = function()
  require('telescope').extensions.vim_bookmarks.all({
    tail_path = true,
    shorten_path=false
  })
end

but it doesn't work, not being an expert in lua I would need a hand.

lua require('telescope.builtin').builtin({include_extensions = true})

this particular extension will raise an error with the following message:

5108: Error executing lua ...lugged/telescope.nvim/lua/telescope/builtin/internal.lua:46: bad argument #1 to 'getinfo' (function or level expected)

I've narrowed it down to this line https://github.com/nvim-telescope/telescope.nvim/blob/master/lua/telescope/builtin/internal.lua#L44, not sure what that fn is expecting to get though. It looks like it doesn't accept this https://github.com/tom-anders/telescope-vim-bookmarks.nvim/blob/main/lua/telescope/_extensions/vim_bookmarks.lua#L159 as a table

tom-anders / telescope-vim-bookmarks.nvim Goto Github PK

telescope-vim-bookmarks.nvim's People

Contributors

Stargazers

Watchers

Forkers

telescope-vim-bookmarks.nvim's Issues

My config

Error

Recommend Projects

Recommend Topics

Recommend Org

Jobs