tomaszdurka / codegenerator Goto Github PK

Reproduce with

<?php

require_once dirname(__DIR__) . '/vendor/autoload.php';

class A {
    public function foo($param1 = null) {
    }

    public function bar($param1 = null, $param2) {
    }

    public function baz($param1 = null, $param2 = null) {
    }
}

echo \CodeGenerator\MethodBlock::buildFromReflection(new ReflectionMethod('A', 'bar'))->dump() . PHP_EOL;

Output

public function bar($param1, $param2) {
}

Output should be

public function bar($param1 = null, $param2) {
}

I think the problem lies in ParameterBlock:: buildFromReflection() which uses ReflectionParameter::isOptional() to determine if a default-value should be used. ReflectionParameter::isOptional() is actually false if a a parameter with a default value is followed by one with no default value, as it can't be omitted in a function-call.
It's either that or a misuse of the _optional field-variable, depending on what the semantics of _optional are.