tomorrowdata / iottly-sdk-python Goto Github PK

json.dumps raise a TypeError if there is a python object not JSON serializable inside the send payload.

Maybe we could add a new argument for the SDK init that gives a function to handle this objects.

This function could be provided to the json.dumps default argument.

Il problema è che si sta cercando di chiamare la call_agent da dentro la callback on_agent_status_changed.
La call_agent verifica che l'agent abbia una versione compatibile (>=1.8).
Quando viene triggerata la callback on_agent_status_changed("started"), l'agent non ha ancora fatto in tempo a mandare la sua versione, quindi la call_agent non viene chiamata.

How to reproduce

>>> import iottly_sdk
>>> sdk = iottly_sdk.IottlySDK("Wilson")
>>> sdk.start()
>>> Exception in thread receiver_t:
Traceback (most recent call last):
  File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.5/dist-packages/iottly_sdk-1.3.0-py3.5.egg/iottly_sdk/iottly.py", line 486, in _receive_msgs_from_agent
    self._process_msg_from_agent(msg)
  File "/usr/local/lib/python3.5/dist-packages/iottly_sdk-1.3.0-py3.5.egg/iottly_sdk/iottly.py", line 506, in _process_msg_from_agent
    self._handle_signals_from_agent(msg['signal'])
  File "/usr/local/lib/python3.5/dist-packages/iottly_sdk-1.3.0-py3.5.egg/iottly_sdk/iottly.py", line 519, in _handle_signals_from_agent
    self._on_connection_status_changed_cb(status)
TypeError: 'NoneType' object is not callable

Cause

Thanks to @Oscar-Campo and @lupodellasleppa 🎖️

When the SDK initializes, it gives no feedback as to if the start() has completed or not.

This could lead to third party applications considering the SDK as started, while in reality it's still starting.

It could happen, for example, that the SDK has not yet received the agent version from the agent, while trying to call the call_agent() method, resulting in a InvalidAgentVersion error.

The sdk.send() doesn't work when the payload is greater than 65535 bytes (TCP packet max size).

Nothing is sent to the Agent and no exception is raised. sdk.send() stops working.

Probably we need to use socket.send() instead of socket.sendall() and manage the size of payload.

When the SDK is run in a process with not enough permission to connect to the socket no error is notified to the user 😞

A message is sent automatically to the agent when an exception is raised from the callback.

Perhaps this must be written inside SDK documentation.