tonnyl / light Goto Github PK

Hi,

I have imported Light in my project to show, in special cases, long String alerts. The issue appears when the String has 3 lines or more, for example:

"Welcome"
System.lineSeparator()
"Name: Diego Gómez Pérez"
System.lineSeparator()
"You have agreed at 10:00 am"

With these Strings, Light shows:

"Welcome
Name: Diego Gómez ..."

I think that you have a maximum of allowed lines, could you please solve it in some way?

Thanks!

This my dependencies code for Light:
implementation "io.github.tonnyl:light:${versions.light}"
and i am getting this error: Failed to resolve: io.github.tonnyl:light:1.1.0.
Looks the particular release is not available on jcenter().

Anytime i display the snack in a fragment where i have recycler view. It removes the padding on the first row of the recyclerview

Admob banners take space too.
What's the best way to show them, yet also allow to show snackbars?
I didn't see it mentioned on Admob website:
https://support.google.com/admob/answer/6128877?hl=en
Or of snackbars:
https://material.io/guidelines/components/snackbars-toasts.html#snackbars-toasts-specs

Thank you for this nice library!

I was surprised to find Companion references in your README, leaking an implementation detail of your library (= using Kotlin).
But as same time you're using @JvmStatic so you're already generating functions like Light.success(...).

Why not updating the README to avoid using this ugly Companion notation in Java? ;)

Bonus: your Light.kt is only including static functions. My advise would be to remove 2 indentation levels by reformating Light.kt like this example:

@file:JvmName("Light")
package io.github.tonnyl.light

fun success(....) { ... }

Only bad point: seems not possible to have javadoc for this class :/