tonobo / hcloud-ruby Goto Github PK

We found a situation in which the doubles tests do not run successfully with random order. The following seed breaks the tests:

bundle exec rspec -t doubles --order rand --seed 50938

When I implemented firewalls, I forgot to return the actions from the API to the caller.

The API returns a JSON

{
    "actions": [...],
    "firewall": {...}
}

but firewall = client.firewalls.create(...) only returns the firewall.

The behavior of other create methods with actions is:

action, foo = client.foos.create() # e.g. floating IP
action, foo, next_actions = client.foos.create() # e.g. servers and volumes

The natural behavior of firewalls thus should be:

actions, fw = client.firewalls.create()

• https://docs.hetzner.cloud/#firewalls
• https://docs.hetzner.cloud/#firewall-actions

Currently the update method returns a new object, but it should also update itself.

• https://docs.hetzner.cloud/#placement-groups

The auto_pagination handler will trigger a per page fetch for each entry.

• Images have Actions
• Servers have metrics and can change it's rDNS

Build gem and push it to the rubygem mirror.

activesupport is currently pinned to the last 6.* version due to some autoload problems with 7.*.

GitHub is pretty weird with it's workflows. We currently can't trigger any CI Runs for external contributions. Seems like we need to add an workflow_dispatch trigger:

https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow

It's been a while since someone worked on this project so there is a bit of a gap between what you can do through the API and through this gem, so we should go through the API and check what is actually missing and then create issues to close the gaps (e.g. LoadBalancer are missing as well as PlacementGroups)

So all unchecked entries are not yet checked for differences - based on the official docs

• Actions
• Certificates missing #26
• Certificate Actions missing #26
• Datacenters
• Firewalls missing #25
• Firewall Actions missing #25
• Floating IPs - field:labels missing #12
• Floating IP Actions
• Images - field:labels missing #12
• Image Actions - get action(s) missing #30
• ISOs
• Load Balancers missing #29
• Load Balancer Actions missing #29
• Load Balancer Types missing #29
• Locations
• Networks - field:labels missing #12 #26
• Network Actions get action(s) + change_ip_range missing
• Placement Groups missing #27
• Pricing missing #28
• Servers - field:labels missing #12 + get-metrics missing
• Server Actions - change_dns_ptr missing #30
• Server Types
• SSH Keys - field:labels missing #12
• Volumes - field:labels missing #12
• Volume Actions

• https://docs.hetzner.cloud/#load-balancers
• https://docs.hetzner.cloud/#load-balancer-actions
• https://docs.hetzner.cloud/#load-balancer-types

Thanks for maintaining this gem. It's already helpful - I use it to manage my son's Minecraft server (which is, as you can imagine, pretty essential for a 14-year old).

Keep up the good work!

https://docs.hetzner.cloud/#pricing

We are using doubles tests as our primary unit testing mechanism now (spec/hcloud/ and spec/doubles/). We are planning to keep the older fake service tests and use them as integration tests for the real API.

At the moment they are in the folder spec/integration/, but still behave in the old way using the fake service from spec/fake_service/. We want to completely delete the fakes in spec/fake_service/ and instead use the real API for testing.

A quick first test showed that this will require several adjustments to the code, because currently the tests expect to start in a clean project with 0 other resources. This is not granted in the CI project. We have to make sure that tests also work when there are already other resources in the cloud project.

• https://docs.hetzner.cloud/#certificates
• https://docs.hetzner.cloud/#certificate-actions

Thanks for the gem,
how can I "busy wait" for an Action to complete. This does not update the status of the action:

action,server = c.servers.create(name: "moo5", server_type: "cx11", image: "ubuntu-16.04")

while true do
  puts action.status
  puts server.status
  puts server.public_net["ipv4"]
  sleep 1
end

In general how to I refetch a server or any other resource for status updates ?

Rspec tests usually follow a human-readable schema that's almost an English sentence.

We currently check whether a Typhoeus stub was called with expect(stub.times_called).to eq(1). Side note: times_called uses Typhoeus private data.

Rspec, at least for yield_control, has expect { ... }.to yield_control.twice and similar tests. Following the same design as yield_control we could implement the following have_been_called matcher:

expect(stub).to have_been_called
expect(stub).to have_been_called.once
expect(stub).to have_been_called.exactly(k).times
expect(stub).to have_been_called.at_most(k).times
expect(stub).to have_been_called.at_least(k).times

Hetzner Cloud released ARM64 servers, we have to check whether everything is supported and add missing functionality to hcloud-ruby.

• Server Types support a filter architecture in queries (Docs)
• Server Types have a new attribute architecture (Docs)
• Images support a filter architecture in queries (Docs)
• Images might also have an attribute architecture? Could not find it in the API Docs, though
• ISOs have two new filters architecture and include_architecture_wildcard (Docs)
• ISOs have a new attribute architecture (Docs)

I did not find primary IPs in the issue list or in the existing code

Hi,
I updated from 1.1.0 to 1.2.0 and I cannot create ssh keys anymore. It aborts with this error:

undefined method `blank?' for "Beaker-runner-fv-az186-249-4769264692-2023-11-01_09_28_37_305488169":String
/home/runner/work/puppet-systemd/puppet-systemd/vendor/bundle/ruby/3.2.0/gems/hcloud-1.2.0/lib/hcloud/ssh_key_resource.rb:15:in `create'
/home/runner/work/puppet-systemd/puppet-systemd/vendor/bundle/ruby/3.2.0/bundler/gems/beaker-hcloud-5afc510af942/lib/beaker/hypervisor/hcloud.rb:67:in `create_ssh_key'
/home/runner/work/puppet-systemd/puppet-systemd/vendor/bundle/ruby/3.2.0/bundler/gems/beaker-hcloud-5afc510af942/lib/beaker/hypervisor/hcloud.rb:29:in `provision'

I noticed that between the 1.1.0 and 1.2.0 release a bunch of validation got added that checks strings with .blank?. That's not a Ruby method for the String class but a Rails method. I assume the dependency is missing.

Steps to reproduce:

require 'hcloud'
# https://github.com/bastelfreak/beaker-hcloud/blob/label2/lib/beaker-hcloud/ssh_data_patches.rb
require_relative 'lib/beaker-hcloud/ssh_data_patches'
client = ::Hcloud::Client.new(token: token)
ssh_key_name = 'foo1234'
ssh_key = SSHData::PrivateKey::ED25519.generate
key_file = Tempfile.create(ssh_key_name)
File.write(key_file.path, ssh_key.openssh(comment: ssh_key_name))
hcloud_ssh_key = client.ssh_keys.create(name: ssh_key_name, public_key: ssh_key.public_key.openssh(comment: ssh_key_name))

This gives me:

NoMethodError: undefined method `blank?' for "foo123":String
```

After some digging around I noticed that activemodel has no version constraints which is quite bad. In 6.x `.blank?` is available, but not in 7 (or it got moved and we need to require something else, but I've no time to dig into this right now).

When using the IPv6 address ::/0 in a firewall rule, we will get the Ruby symbol :":/0" as a parsed response. I was able to trace it down to Oj.load changing the string in parsed_json in entry_loader.rb.

To my understanding, this is probably related to this discussion: ohler55/oj#285

I have to admit, I do not get the arguments of the Oj developers, either. If Oj.load('{"foo": ":"}') does not work, this looks broken. If I get them right, then using the default mode: :object is almost always the wrong thing to do. When parsing JSON data that was not generated with Oj, it seems we need to use mode: :compat.

Here's a minimal reproducing example:

require 'oj'

data = '{"foo": ["::/0"]}'
p "Input data is:"
p data

puts "\n"
p "Oj parsed result with default mode is:"
p Oj.load(data)

puts "\n"
p "Oj parsed result with compat mode is:"
p Oj.load(data, mode: :compat)

with the output:

"Input data is:"
"{\"foo\": [\"::/0\"]}"

"Oj parsed result with default mode is:"
{"foo"=>[:":/0"]}

"Oj parsed result with compat mode is:"
{"foo"=>["::/0"]}

hetznercloud/cli@bf79862

it might make sense to delineate it from:
https://github.com/floriandejonckheere/hcloud