GithubHelp home page GithubHelp logo

torba-rails's People

Contributors

lucasmazza avatar nashbridges avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

amikishiyev

torba-rails's Issues

Can't deploy on Heroku

I'm trying to deploy a rails application with Torba on heroku, but the asset:precompile don't run the torba pack. The variables TORBA_HOME_PATH and TORBA_CACHE_PATH are setted in the Heroku config vars. The log of heroku deploy is:

remote: -----> Preparing app for Rails asset pipeline
remote:        Running: rake assets:precompile
remote:        rake aborted!
remote:        Torba::Errors::MissingPackages: [#<Torba::Package:0x007ff5636fb980 @name="tooltipster", @remote_source=#<Torba::RemoteSources::GithubRelease:0x007ff563704a08 @source="iamceege/tooltipster", @tag="3.2.6", @repository_user="iamceege", @repository_name="tooltipster", @url="https://github.com/iamceege/tooltipster/archive/3.2.6.zip", @digest="tooltipster-a0a331b0">, @import_paths=["css/themes/tooltipster-light.css", "css/tooltipster.css", "js/jquery.tooltipster.js"], @load_path="vendor/torba/tooltipster-edaec908">]
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/torba-1.0.0/lib/torba/manifest.rb:121:in `verify'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/torba-1.0.0/lib/torba.rb:69:in `verify'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/torba-1.0.0/lib/torba/verify.rb:6:in `<top (required)>'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.5.1/lib/active_support/dependencies.rb:274:in `require'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.5.1/lib/active_support/dependencies.rb:274:in `block in require'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.5.1/lib/active_support/dependencies.rb:240:in `load_dependency'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.5.1/lib/active_support/dependencies.rb:274:in `require'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/torba-rails-1.0.0/lib/torba/rails.rb:17:in `block in <class:Engine>'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/initializable.rb:30:in `instance_exec'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/initializable.rb:30:in `run'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/initializable.rb:55:in `block in run_initializers'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/initializable.rb:54:in `run_initializers'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/application.rb:352:in `initialize!'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/config/environment.rb:5:in `<top (required)>'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/application.rb:328:in `require'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/application.rb:328:in `require_environment!'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/railties-4.2.5.1/lib/rails/application.rb:457:in `block in run_tasks_blocks'
remote:        /tmp/build_d7409fa1557cbbf8209532e4c0425163/vendor/bundle/ruby/2.2.0/gems/sprockets-rails-3.0.1/lib/sprockets/rails/task.rb:62:in `block (2 levels) in define'
remote:        Tasks: TOP => environment
remote:        (See full trace by running task with --trace)
remote:  !
remote:  !     Precompiling assets failed.
remote:  !
remote:  !     Push rejected, failed to compile Ruby app.
remote: 
remote:  !     Push failed

I tested the https://github.com/torba-rb/torba-rails deploy on heroku and get the same error.

Any idea why the torba pack is not running in the asset:precompile?

Rails 6 support 

Bundler could not find compatible versions for gem "thor":
  In Gemfile:
    rails (= 6.1.2) was resolved to 6.1.2, which depends on
      railties (= 6.1.2) was resolved to 6.1.2, which depends on
        thor (~> 1.0)

    torba-rails (~> 1.0) was resolved to 1.0.2, which depends on
      torba (~> 1.0) was resolved to 1.0.1, which depends on
        thor (~> 0.19.1)

CI Build improvements

Hello,

In our CI Setup we first install the gems and precompile our assets, the resulting files are then shared between our parallel test executors (so they don't have to reinstall gems/build assets).

The disadvantage here is that I must share the complete torba cache and torba path else torba complains it is not run (even when the assets are precompiled already).

Would it be possible to disable or let torba known that its job is already done?
This would help speeding up the CI builds (since they don't have to download the complete assets path)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.