touchlab / kmmbridgegithubworkflow

KMM Bridge Github Workflow

Github actions workflows for use with KMMBridge

kmmbridgegithubworkflow's Issues

Add a java version param

See context: https://kotlinlang.slack.com/archives/CTJB58X7X/p1673029672331949

AGP requires jvm 17. To discuss.

Add ability to set custom netrc credentials

Right now, our docs on Artifactory recommend setting up a custom github action rather than using this one, because different netrc credentials are needed. This will also come up for other backends. We should add the ability to pass credentials manually so the workflows in this repo are usable in more non-github scenarios.

Kevin update:

Updated the workflow to take netrc params. the netrc params are optional. If none are provided, the workflow assumes the GitHub Packages config.

Params:

• inputs.netrcMachine
• secrets.netrcUsername
• secrets.netrcPassword

Make sure to set workflow to v0.7.

Example:

name: KMM Bridge/iOS Publish
on:
  workflow_dispatch:
#  push:
#    branches:
#      - "main"
jobs:
  call-kmmbridge-publish:
    uses: touchlab/KMMBridgeGithubWorkflow/.github/workflows/[email protected]
    with:
      netrcMachine: maven.pkg.github.com # <- Put machine here
    secrets:
      netrcUsername: kpgalligan # <- username
      netrcPassword: ghp_ASRTASRTARSTARSTARST # <- password, PAT for GitHub
      PODSPEC_SSH_KEY: ${{ secrets.PODSPEC_SSH_KEY }}

This has been only been tried with the same server that will work by default, maven.pkg.github.com. It should be tested with other servers like Artifactory.

Also need to add docs for passing in workflow params, and maybe an integration workflow.

Passing environment variables to the workflow

I am not sure if this is a real issue or if I lack some GHA experience.
I have the following workflow

name: iOS Publish
on:
  pull_request:
  workflow_dispatch:

#  push:
#    branches:
#      - "main"

env:
  gitHubUserName: ${{ secrets.GH_USER_NAME }}
  gitHubAccessToken: ${{ secrets.GH_ACCESS_TOKEN }}

jobs:
  publishIOS:
    name: Publish iOS
    permissions:
      contents: write
      packages: write
    uses: touchlab/KMMBridgeGithubWorkflow/.github/workflows/[email protected]
    with:
      jvmVersion: 17
      runsOn: ubuntu-20.04
      versionBaseProperty: LIBRARY_VERSION

The KKMBridge workflow launches a gradle task under the hood that executes some code in my underlying gradle configuration in the Android project. This project needs some env variables set by the GHA. In that case gitHubUserName and gitHubUserName.
Unfortunately, when setting the env variables in this workflow it seems to be not propagated down to the KMMBridge workflow. gitHubUserName and gitHubUserName are always null when the underlying gradle tasks in the Android project are executed.

Who has an idea of a potential fix?