2flicks's People
Forkers
tketa2flicks's Issues
Thanks!
Hello! Thank you for submitting the second homework for CoderSchool React Class
Great ✨
- Really clean code! This is very good, didn't have to change many things in here.
- Good job catching the errors when fetching movies in
componentWillMount
Not so great yet 🚩
- Do not leave
console.log
in the code :) props
is the named of properties given to your component. I suggest not creating another variable calledprops
. For example:
// const props = this.props.navigation.state.params;
const navigationParams = this.props.navigation.state.params;
Or
// const props = this.props.movie (don't do that)
- Consider using
eslint
to spot unused imports and have consistent code quality across your code. We haven't had a dedicated time to do this, so it's mostly our fault. You can install it really easily by typing
yarn add -D eslint
eslint --init
- I recommend chosing the guidelines from a popular company like Airbnb or Google. Then you can override some specific rules you don't like. Take a look at the
.eslintrc.js
file in my Suggestions for example of how to do that.
Good assignment overall
If there's anything unclear with the feedback given here, please let us know!
Thanks!
Hello! Thank you for submitting the second homework for CoderSchool React Class
Great job doing the two NowPlaying
and TopRated
screens Minh! Not many people reached that stage, you can be proud of yourself.
Great ✨
- Really clean code! This is very good, didn't have to change many things in here.
- Good job again mastering navigation and having the
StackNavigator
nested in theTabNavigator
Not so great yet 🚩
props
is the named of properties given to your component. I suggest not creating another variable calledprops
. For example:
// const props = this.props.navigation.state.params;
const navigationParams = this.props.navigation.state.params;
Or
// const props = this.props.movie (don't do that)
- Consider using
eslint
to spot unused imports and have consistent code quality across your code. We haven't had a dedicated time to do this, so it's mostly our fault. You can install it really easily by typing
yarn add -D eslint
eslint --init
- I recommend chosing the guidelines from a popular company like Airbnb or Google. Then you can override some specific rules you don't like. Take a look at the
.eslintrc.js
file in my Suggestions for example of how to do that.
Good assignment overall
If there's anything unclear with the feedback given here, please let us know!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.