trangvang / 2flicks Goto Github PK

Hello! Thank you for submitting the second homework for CoderSchool React Class 🎉! The main focus of this assignment was to introduce you to working with React Native, rendering items in a FlatList, and dealing with navigation.

Great ✨

• Really clean code! This is very good, didn't have to change many things in here.
• Good job catching the errors when fetching movies in componentWillMount

Not so great yet 🚩

• Do not leave console.log in the code :)
• props is the named of properties given to your component. I suggest not creating another variable called props. For example:

// const props = this.props.navigation.state.params;
const navigationParams = this.props.navigation.state.params;

Or

// const props = this.props.movie (don't do that)

• Consider using eslint to spot unused imports and have consistent code quality across your code. We haven't had a dedicated time to do this, so it's mostly our fault. You can install it really easily by typing

yarn add -D eslint
eslint --init

• I recommend chosing the guidelines from a popular company like Airbnb or Google. Then you can override some specific rules you don't like. Take a look at the .eslintrc.js file in my Suggestions for example of how to do that.

Good assignment overall 👏👏 You understand how to use the navigation, and pass informations to new screens, which was the goal ✅

If there's anything unclear with the feedback given here, please let us know!

Hello! Thank you for submitting the second homework for CoderSchool React Class 🎉! The main focus of this assignment was to introduce you to working with React Native, rendering items in a FlatList, and dealing with navigation.

Great job doing the two NowPlaying and TopRated screens Minh! Not many people reached that stage, you can be proud of yourself.

Great ✨

• Really clean code! This is very good, didn't have to change many things in here.
• Good job again mastering navigation and having the StackNavigator nested in the TabNavigator

Not so great yet 🚩

• props is the named of properties given to your component. I suggest not creating another variable called props. For example:

// const props = this.props.navigation.state.params;
const navigationParams = this.props.navigation.state.params;

Or

// const props = this.props.movie (don't do that)

• Consider using eslint to spot unused imports and have consistent code quality across your code. We haven't had a dedicated time to do this, so it's mostly our fault. You can install it really easily by typing

yarn add -D eslint
eslint --init

• I recommend chosing the guidelines from a popular company like Airbnb or Google. Then you can override some specific rules you don't like. Take a look at the .eslintrc.js file in my Suggestions for example of how to do that.

Good assignment overall 👏👏 You understand how to use the navigation, and pass informations to new screens, which was the goal ✅

If there's anything unclear with the feedback given here, please let us know!