transloadit / android-sdk Goto Github PK

Establish the automated release GH-Actions workflow in this repo also

Refs https://github.com/transloadit/team-internals/issues/26#issuecomment-804054632

onUploadPogress should be onUploadProgress

1. AssemblyResponse::getId throws exceptions instead of doing its job because it looks for "id" instead of ”assembly_id.”
2. Submitting an assembly requires an Activity when a Context should be enough. In my case, I use a service for managing the uploads: having to provide an activity really feels like a hack.
3. The upload progress is not updated frequently enough to use it to update a progress bar properly.

Additional feature request:
Upload progress and completion/failure callbacks for individual uploads.

We'll need to rewrite some parts of the SDK in order to move it from deprecated methods to more recent implementations in the Java-SDK >= 1.0.0

Maybe we can take into account those ideas from an older issue (#4):

• Submitting an assembly requires an Activity when a Context should be enough. In my case, I use a service for managing the uploads: having to provide an activity really feels like a hack.
• Upload progress and completion/failure callbacks for individual uploads.

Maybe we should also consider pairing up and or do a complete rewrite @Acconut.

We could also do it the hard with Kotlin, as referenced here: #2

Since Kotlin is a first class language on Android now (https://developer.android.com/kotlin/), people might be interested in building parts of their mobile application using Kotlin. The good thing is that Kotlin is (fully?) inter-operable with Java, so we do not need another SDK for it but an example might be helpful for users who want to use the Android SDK with Kotlin.

I'm pretty sure the method can be implemented using only the application context (a Context object, which is a superclass of Activity).

Current signature:
public AndroidAsyncAssembly newAssembly(com.transloadit.sdk.async.AssemblyProgressListener listener, android.app.Activity activity);

Desired signature:
public AndroidAsyncAssembly newAssembly(com.transloadit.sdk.async.AssemblyProgressListener listener, android.content.Context context);

Having to provide an Activity is really problematic, as activities are only available when the user is interacting with the app. Therefore I cannot provide an activity from a worker, which I'd like to use in order to offer my users a delayed upload (so they can select their files offline and have the worker upload them afterward when they are back online). I cannot provide an activity either from a service, from which I handle failed downloads (and from which I'd also like to handle failed uploads).