trendyol / ios-guidelines Goto Github PK

Hey. I've had a look at the documentation, good work. But just a quick browse and when I want to search for swift keywords, collapsed sections won't let me. Maybe the codes can be uncollapsed. I just wanted to give a suggestion 🧡

should be added into repo.

should be added into repo.

Analytics Architecture Guideline should be added into repo.

App Architecture Guideline should be added into repo.

App Architecture Guideline should be added into repo.

should be added into repo.

should be added into repo.

First of all, nice documentation 👍
Just have one suggestion if you like to check over:
Ternary Operator usage in Patterns topic, relating it to build time problems making usage of ternary a little ambiguous.
Same for nil coalescing operator, I suggest separating "avoiding long-complex expression usage" with those two.
Example:

let top: UIView? = UIView()  
let bottom: UIView? = UIView()  
let width: CGFloat = 10  
let height: CGFloat = 10. 
// WRONG (Complex expression)
let size = CGSize(width: width, height: height + (top?.bounds.height ?? 0) + (bottom?.bounds.height ?? 0) + 33). 

let top: UIView? = UIView()  
let bottom: UIView? = UIView()  
let width: CGFloat = 10  
let height: CGFloat = 10  
// SEPARATION (Complex expression)  
let firstExp = top?.bounds.height ?? 0 + height  
let secondExp = bottom?.bounds.height ?? 0 + 33 
let size = CGSize(width: width, height: firstExp + secondExp). 

Thanks :)

Architecture Decision Records should be added into repo.

should be added into repo.

Trendyol iOS Open Source References should be added into repo.

should be added into repo.