Flickering screen during PIN verification about trezor-core

[prusnak]

The problem is here:

trezor-core/src/trezor/pin.py

Line 9 in d86abc4

if progress == 0:

If show_pin_timeout is called with progress == 0 the screen is cleared.

If timeout is bigger than 1000 seconds, show_pin_timeout is called with progress == 0 multiple times, each time performing a clear screen.

Not sure what is the easiest solution to this. Quick hack would be that show_pin_timeout remembers last value of progress and this is compared on each call. Clear screen is performed only if progress == 0 and last_progress != progress.

@jpochyla what do you think?

[tsusanka]

LGTM. The screen does not flicker after 10th try. Branch master c55b655.

Videos: https://streamable.com/6hy4v http://streamable.com/lwq0e

[tsusanka]

Ping @jpochyla . Or have you discussed this in person?

[jpochyla]

Possible fix in 7533409

[prusnak]

Seems like a good fix!

Can we prepare a firmware with the commit and try entering PIN on the device incorrectly 10 times? (essentialy when we need to wait for more than 1000 seconds, ideally at least 8000 seconds)