Comments (3)
I think it makes sense to differentiate between the two functions for now even though they behave the same. In the future we might want to implement different behavior for each, i.e. we might not want check_pin() to unlock the storage. However, I noticed that during dry run recovery we do not check the PIN if config.has_pin() returns false. We should not trust what config.has_pin() returns, because the stored value is not cryptographically validated.
Changes:
- Removed the code duplication in modtrezorconfig.c.
- Verify the return value of config.has_pin() in dry run recovery.
- Improved UI messages in dry run recovery.
See #536
Test cases:
TC1: Perform a dry run recovery ("Check recovery seed" in Trezor Wallet) on a device which does not have a PIN set. Verify that the user is not asked to enter PIN and dry run proceeds as expected.
TC2: Perform a dry run recovery on a device which has a PIN set. Enter the correct PIN. Verify that dry run proceeds as expected.
TC3: Perform a dry run recovery on a device which has a PIN set. Enter an incorrect PIN. Verify that the dry run recovery is aborted.
from trezor-core.
Well done! Waits for review in #536
from trezor-core.
Closed by #536, test cases moved to #550.
from trezor-core.
Related Issues (20)
- Passphrase dialog should cleanup the UI HOT 4
- Flickering screen during PIN verification HOT 5
- Swiping up and down when signing cardano transaction leads to blank screen HOT 1
- JS lib to verify SegWit P2SH addresses HOT 1
- Safety check failed error after upgrading to 1.8.0 HOT 1
- Display Custom Locktime On Trezor Screen for BTC HOT 6
- Trezor T freezing during dry run recovery HOT 10
- [Gitlab CI] build firmware of each commit HOT 1
- Keychain.derive and path validations HOT 2
- Test Monero master against trezor-core master HOT 1
- Trezor actions are slow HOT 3
- Treezor model T device shows a completely white screen and doesn't start anymore HOT 2
- U2F is broken in master
- Document script_type HOT 1
- U2F: Response packets not properly zeroed
- Monero finalization HOT 3
- Protection of passphrase against keylogging and screenshot ? HOT 4
- Trezor T firmware buggy from upper case bech32 addresses HOT 4
- Ubuntu 18.04 unmet dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trezor-core.