trinitycore / trinitycorecustomchanges

TrinityCore 3.3.5a custom patches, read wiki to get diffs

TrinityCore (3.3.5)

---

• Build Status
• Introduction
• Requirements
• Install
• Reporting issues
• Submitting fixes
• Copyright
• Authors & Contributors
• Links

Build Status

master	3.3.5	wotlk_classic

Introduction

TrinityCore is a MMORPG Framework based mostly in C++.

It is derived from MaNGOS, the Massive Network Game Object Server, and is based on the code of that project with extensive changes over time to optimize, improve and cleanup the codebase at the same time as improving the in-game mechanics and functionality.

It is completely open source; community involvement is highly encouraged.

If you wish to contribute ideas or code, please visit our site linked below or make pull requests to our Github repository.

For further information on the TrinityCore project, please visit our project website at TrinityCore.org.

Requirements

Software requirements are available in the wiki for Windows, Linux and macOS.

Install

Detailed installation guides are available in the wiki for Windows, Linux and macOS.

Reporting issues

Issues can be reported via the Github issue tracker.

Please take the time to review existing issues before submitting your own to prevent duplicates.

In addition, thoroughly read through the issue tracker guide to ensure your report contains the required information. Incorrect or poorly formed reports are wasteful and are subject to deletion.

Submitting fixes

C++ fixes are submitted as pull requests via Github. For more information on how to properly submit a pull request, read the how-to: maintain a remote fork. For SQL only fixes, open a ticket; if a bug report exists for the bug, post on an existing ticket.

Copyright

License: GPL 2.0

Read file COPYING.

Authors & Contributors

Read file AUTHORS.

Links

• Website
• Wiki
• Forums
• Discord

trinitycorecustomchanges's Issues

3.3.5-vas-autobalance // it does not work autonomously

Description:

After downloading and compiling the "3.3.5-vas-autobalance" branch, autobalance seems to have a "strange" behavior:

if a player alone (not a gm) enters an instance, a message appears announcing that "autobalance" has detected the presence of 1 player on the map, but no changes are made to the health and damage of the mobs.

If you bring a gm to the player's position in the same instance (.appear player-name) and the gm executes the command ".vas checkmaps", the mobs' health and damage values ​​are immediately changed.

Is this the normal behavior?
If so, can this behavior be made automatic and without the need for GM's intervention? (players have no .vas commands).

Branch(es):

3.3.5-vas-autobalance

dynamic resurrect

I found this patch long long time ago, i am sure on current state it can be exploited, measures needs to be taken to stop people to click release while combat with boss is in progress. (we can do that already because the lk fight)

https://pastebin.com/cMt825nX

sub-categories on telenpc

add to telenpc the posibility of create sub categories, on that way it can be more compact.

ie:

Cities
|--Neutral
|  |-Dalaran
|  |-Shattrah
|  \-Argent Tournament
|--Aliance
|  |-Ironforge
|  |-Stormwind
|  |-Exodar
|  \-Darnassus
|--Horde
Instances
|--Eastern Kingdom
|--Kalimdor
|  |-Caverns of time
|  |-Zul Farrak
|  \-other
|--Outland
|--Northrend
Raids
|--Classic
|--BC
|--WOTLK

reagents bank

Description:

i was thinking if it's doable to implement a reagents bank, idk, maybe like 1 tab guild bank.

TC rev. hash/commit:

5ba93a9

255 Support

Are there any plans for the branches to support config to enable level 255 by default or people should do that on their own cores ?

Cannot execute Teleport NPC sql

Why I cant execute setup_npc_teleport.sql on sql/tool to my database??

add to passive anticheat output of people being hacking to chat window

the current way makes messages to loss if you aren't looking to the screen on that exact moment

allow use flying mount as land mounts on maps continental maps / instance

maybe a lot of you know that on wow 4+ you have the chance if you don't have brought fly skill for map 0 and 1 you can still use it as land mount, imho it's a cool feature to port to 3.3.5a
(it may need to be used from a command, ie .mount known_mount_spell_id / .mount known_mount_name / .mount known_mount_link

cata like mass resurrect

I wonder if it's doable to create mass resurrect custom spells or script standard resurrect spells to resurrect every dead on group for wow 3.3.5a

Script to update branches

Write a powershell script to automatically pull from TC main repo and push to this repo and merge into every branch and push every branch, showing the results with which branches conflicted and which worked fine

Racial Traits\Abilities Swap NPC AI

Description:

Racial Traits Swap NPC AI

For a configurable (conf) in game price, you can purchase a racial Traits\Abilities swap on your characters. I have took in account every possible combination of all 66 racial abilities\traits.

Also contains announcement module as well.

Current behaviour:

Working Video, Just need like touch up if you wish it to be a branch for TC Custom.
https://youtu.be/MyzOg2qthZ4

Branch(es):

3.3.5

TC rev. hash/commit:
tested on
parent bf0975f commit 895dbc0

895dbc0

TDB version: CHANGEME Version of the TrinityCore database
TDB 335.21011

Operating system:
Compiled on windows 10 pro

PvP Ranks extra honor

PvP Ranks calls

honor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f);

but then

honor = int32(honor_f);

so the custom extra honor gets lost.

honor_f should probably be changed instead.

c840b87#diff-5589ee47b3a7ad220cff105a8fe7eac3R6854

3.3.5-solocraft database wrong

Description:
3.3.5-solocraft database:

-- Dumping structure for table characters.custom_solocraft_character_stats
DROP TABLE IF EXISTS `custom_solocraft_character_stats`;
CREATE TABLE IF NOT EXISTS `custom_solocraft_character_stats` (
  `GUID` tinyint(3) unsigned NOT NULL,
  `Difficulty` float NOT NULL,
  `GroupSize` int(11) NOT NULL,
  `SpellPower` int(10) unsigned NOT NULL DEFAULT '0',
  `Stats` float NOT NULL DEFAULT '100',
  PRIMARY KEY (`GUID`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin;

guid should use int!
Current behaviour:

use tinyint will cause over 255 guid character wrong!

Expected behaviour:

tinyint to int

Steps to reproduce the problem:

n/a

**Branch(es):**3.3.5-solocraft

autoequip good idea for gms testing things

https://community.trinitycore.org/topic/12013-new-autoequipe/

[Anticheat] ‘teleport plane hack detection’ not working properly

players can still use teleport plane hack

crossfaction bg

A lot of people uses this patch on small servers.

https://gist.github.com/Aokromes/fe5ce4d06f69e2ff5e62ddacdc4291c9

ПОРНУШКА

Description:

CHANGEME Description of the problem or issue here.

Current behaviour:

CHANGEME Tell us what happens.
If this is a crash, post the crashlog (upload to https://gist.github.com/).

Expected behaviour:

CHANGEME Tell us what should happen instead.

Steps to reproduce the problem:

1. CHANGEME Step 1 include entries of affected creatures / items / quests with a link to the relevant wowhead page.
2. Step 2
3. Step 3

Branch(es):

Writing server debug on console will return the best results for reporting bugs (3.3.5a for now)
CHANGEME 3.3.5, master or both

TC rev. hash/commit:

CHANGEME Copy the first line of the worldserver, authserver or bnetserver startup.
For example: TrinityCore rev. 0000000000 2000-01-09 11:31:41 +0100 (my branch) (Win64, RelWithDebInfo, Static) (bnetserver)

TDB version: CHANGEME Version of the TrinityCore database

Operating system: CHANGEME OS

Skip DK Module Broken

Description:

The Skip DK module has a couple issues.

If I enable the starter skip, I spawn in orgrimmar, but the quest turn in to Thrall is bugged. The quest log seems to think it is "complete" and I have the quest item, but the dialogue with Thrall will not advance.

If I disable the starter skip and try to use the dialogue with Lich King, nothing happens.

Steps to reproduce the problem:

1. Enable DK skip module
2. Create new Death knight
3. Login to character
   4a. Run to Thrall, try to turn in quest
   4b. Talk to Lich King, select "I wish to skip the Death Knight starter Questline"

Branch(es):
3.3.5a

TC rev. hash/commit:
b9450bc

TrinityCore rev. b9450bc+ 2022-06-26 21:48:41 +0300 (3.3.5 branch) (Unix, RelWithDebInfo, Static) (worldserver-daemon)

TDB version: 335.22061

Operating system: Ubuntu 21.10

Track custom changes between branches

Create a way for people that are using TrinityCore 3.3.5 Base to track changes in order to merge a custom patch into their core.

Simply put if i to get the changes for the pvprank patch i would need to research the whole core and extract the changes only for the pvprank patchs atm.

I really like the idea to have custom changes into the 3,3,5 branch but having them hidden behind 9000 commits is quite harsh and also people that are intretested in these custom patches would most of the time want to merge 2-3 if not all patches into 1 and use them all on their server, so having a way to see or merge only the changes for the patch will be really usefull.

hide unable to teleport destinations

atm telenpc doesn't shows the categories someone cannot reach because level
i think hidding destinations someone cannot reach can help faster use of it.

flex raid difficulty from legion / bfa

maybe with one custom npc we can "queue" into a raid, the people will be send to 25m raid, with damage and health scaled and 10m mode loot.

https://wow.gamepedia.com/Flexible_Raid

SL like don't need intermediate fly points to travel from one point to a far point

Description:

I am sure a lot of you know on retail you can fly from one fly point to a remote one without known intermediate ones, maybe this can be a cool feature for 3.3.5a.

equip changer npc

https://community.trinitycore.org/topic/225-npc-equip-changer/

Trinity core Hunter RAP

can someone help me solve a problem, on my trinity core server the hunter class whenever it reaches 50k RAP ranged attack power it goes to 0 lowering the damage because every time it reaches 50k it simply turns to zero, can someone help me help solve this?

1v1 Module

Description:
I have a 1v1 Module that is completely module with no major core changes.
is this something you are interested in?

Current behaviour:
Conf and Specialization restrictions implemented.
Conf adjustable.
Cost to fight.
Completely module with no alterations of the core.

Targeted for current 335

NPCBOTS-Can anyone upgrade it?

This is the old version. Can anyone upgrade it?

2016_04_20-New-NPCBots.zip

Anti-cheat database problem

Description:

There is a problem with the anti-cheat database
It is half installed

Current behaviour:

Anticheatsql error.txt

Expected behaviour:

It must be installed correctly

Steps to reproduce the problem:

Branch(es):

3.3.5

TC rev. hash/commit:

TrinityCore rev. 60b75e3+ 2023-03-24 10:52:44 +0100 (3.3.5 branch) (Win64, Debug, Static) (authserver)

TDB version: CHANGEME Version of the TrinityCore database

Operating system: CHANGEME OS

AOE Loot and Mail broken

Description:
world server crashing

zul'furak in tanaris the dirt graves crash world server
creating DK, looting first weapon causes world server to crash
Current behaviour:
working but broken on somethings?

CHANGEME Tell us what happens.
its a world server crash but i dont have access

Expected behaviour:
to not crash the world server?

CHANGEME Tell us what should happen instead.
i should be able to loot the items
Steps to reproduce the problem:

1. make a dk or goto dugeon in tenaris "correct spelling?"
2. loot the graves = crash
3. make dk do first quest loot sword = crash

[3.3.5-aoe-loot-mail-excess] fill max slots of emails when sending items

atm when you have excess items you get 1 email for each excess item, a good idea can be fill the 12 possible slots to send less emails (if there are less than 12 excess item send with 2,3-10,11 items.

race masquerade

https://github.com/Treeston/TrinityCore/tree/3.3.5-race-masquerade

in core dbm

Description:

maybe a good idea can be a way to enable on screen warnings and co for people without addons.

TC rev. hash/commit:

4c0a8ad

TDB version:

N/A

Operating system:

N/A

lower weight for disenchant than greed

Description:

the idea is, think a raid with some people with 2nd spec, you don't "need" a item because it's not your main spec but you want to have it for 2nd spec, but then you find someone rolls disenchant and the roll is 100 and your is 99, and you find your precious item is destroyed.

Current behaviour:

greed and disenchant have same weight so 1-100 rolls of both rolls can lead people wanting a item to have it destroyed.

Expected behaviour:

disenchant have lower weight so 1-100 disenchant rolls never wins 1-100 greed rolls.

Branch(es):

3.3.5

TC rev. hash/commit:

f6e52f6

Get Roles

Description:

in 4.x, we can get roles like tank,heal and dps.but in 3.3.5 this API is lacking.we should add this feature

e.g: like https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/game/Entities/Player/Player.cpp#L15939

Branch(es):

3.3.5

multi talent tree

Description:

how about support 3 or more talents tree

IE:
DPS talents
Tank Talents
Heal Talents
PVP DPS Talents
PVP Tank Talents
PVP Heal Talents

if only 3 maybe the spells for 1st or 2nd talent tree can be scripted for next / previous talents
if more one npc.

TC rev. hash/commit:
3529442
N/R

link guildbanks

Description:

create one way, maybe npc where the guild masters links guild banks to allow have, 12, 18, 24 tabs to store things

Add ability to send logs, events and metrics to discord

Description:

Re-opening previous issue from: TrinityCore/TrinityCore#23871
It would be nice to be able to send metrics and events to discord servers since its one of the top voice platforms available currently

Current behaviour:

No support for discord out of the box

Expected behaviour:

Allow TrinityCore server to communicate with a discord server

Steps to reproduce the problem:

Branch(es):

Both

TC rev. hash/commit:

TDB version: -

Operating system: -

slow down notifications of anticheat

Description:

atm hacks notification spam to much https://i.imgur.com/bxL0evq.png

Expected behaviour:

reduce the amount of notifications to 1 / 5s or 1 / 10s or 1 / 15s maybe config?

Branch(es):

3.3.5

TC rev. hash/commit:

7709837

Operating system: CHANGEME OS

debian 10 x64.

ShowQuestLevelsInDialogs support

• Add support to TrinityCore/TrinityCore#23002 to 3.3.5-custom_link branch , see https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/worldserver/worldserver.conf.dist#L3245

Grumboz_Guild_Warz

another interesthing project https://github.com/BlackWolfsDen/CPP-Grumboz_Guild_Warz

Solocraft parameters not taken into account (worldserver.conf)

Description:

When changing Solocraft parameters in worldserver.conf, nothing is taken into account

Current behaviour:

Changing any Solocraft parameter should be effective.

Expected behaviour:

Default declared parameters value should be overriden by worldserver.conf values.

Steps to reproduce the problem:

1. Set Solocraft.Enable = 0 in worldserver.conf
2. Launch the game => Solocraft is still enabled
   It sticks to default declared value "1" :

bool SoloCraftEnable = 1;

3. Set any other parameter (like Solocraft.Max.Level.Diff) in worldserver.conf, launch the game => nothing happened as expected

Branch(es):

TC> server debug
TC> TrinityCore rev. 243a8eb+ 2021-08-02 03:33:51 +0000 (3.3.5-solocraft branch) (Unix, RelWithDebInfo, Static)
Using SSL version: OpenSSL 1.1.1d 10 Sep 2019 (library: OpenSSL 1.1.1d 10 Sep 2019)
Using Boost version: 1.67.0
Using MySQL version: 100329
Using CMake version: 3.13.4
Compiled on: Linux 5.4.128-1-pve
Automatic database updates are enabled for the following databases: Auth, Characters, World
Worldserver listening connections on port 8086
Realmlist (Realm Id: 1) configured in port 8086
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in /home/wotlk/data/maps. Total size: 291014951 bytes
vmaps directory located in /home/wotlk/data/vmaps. Total size: 1326890216 bytes
mmaps directory located in /home/wotlk/data/mmaps. Total size: 2019979420 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 335.21071
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0

TC rev. hash/commit:

trinity@wotlk:~/server-SC/bin$ ./worldserver
TrinityCore rev. 243a8eb+ 2021-08-02 03:33:51 +0000 (3.3.5-solocraft branch) (Unix, RelWithDebInfo, Static) (worldserver-daemon)

TDB version:

Using World DB: TDB 335.21071

Operating system:

trinity@wotlk:~/server-SC/bin$ cat /etc/debian_version
10.10

Death Knight Starter Area Skip Module

Description:

I have prepared a patch for a Death Knight Starter Area Skip Module based on my project's V2 Legion Consolidated Skip Module.

Current behavior:
Works for both horde and alliance new characters.
When Module is active (Conf = 1) and then a new character Death Knight is created, intro is played (not skippable). Character is then given flags and triggers based on quest completions for the starter areas and give the initial turn in quest after leaving the ebon hold. Alliance DK will be in storm wind with the quest https://www.wowhead.com/quest=13188/where-kings-walk ready for turn in, and Horde DK will be in Orgrimmar with the quest https://www.wowhead.com/quest=13189/saurfangs-blessing. All obtainable key Character Items are in the player's inventory or auto equipped, (Tabard, Weapons, Armors, and such). Spells such as Death Gate works and does return you to the appropriate ebon hold after the DK start zone chain quests are finished.
Tested and working on current 335 with all items and quests and triggers researched for 335 branch.

Preview Video: https://youtu.be/yBOx85LWly8

Branch(es):

3.3.5

TC rev. hash/commit:

Parent: 1ff4a7e (DB/Quest: Fix CompletionText of 'The Balance of Nature')
Branch: 3.3.5
Follows: TDB335.64

CFBG system is not working properly

Description:

FIRST ISSUE IS : cfbg after compilation looks like it works properly, but ingame when you run the battleground, it connects all players to one team and the other team is empty. (for example 2 alliance players join bg and 2 horde players join bg, now who first clicks on enter battleground, if horde player changes it to alliance player and puts it in the team alliance, then all players put it in the alliance team, if he gives the first enter battleground alliance player, then it turns him into a horde player and everyone is in the horde team.
SECOND ISSUE IS : when the battleground starts, it can no longer be joined, it does not send an invitation to the ongoing battleground.

Current behaviour:

no crash nothing happens, everything looks like it works well.

Expected behaviour:

cfbg should work as a balance system, it should assign one player to one team, another to another team, and gradually fill bg to full. and you should definitely join the ongoing battleground.

Steps to reproduce the problem:

1. Compile Core
2. Set up min players for battleground start in my case 4 players for WSG
3. Run Server
4. Create 6 Accounts
5. Log ingame and Join WSG battleground
6. Enter the battleground and check the system as the player connects

Branch(es):

Writing server debug on console will return the best results for reporting bugs (3.3.5a for now)
3.3.5, CFBG or both

TC rev. hash/commit:

TrinityCore rev. 2302a5bc4451+ 2021-08-30 00:48:59 +0000 (master branch) (Win64, RelWithDebInfo, Static)

TDB version: TDB 335.21081

Operating system: Win64

mop like area loot

i wonder if it's doable to create wow mop like AOE loot.

support mail items in raid when bag is full

Description:
After CTM,we know that if in raid/dungeons, kill boss and loot,bag is full. after return home. you can receive mail with items from postmaster.

Current behaviour:

n/a

Expected behaviour:

like Description.

Steps to reproduce the problem:

1. kill boss in raid
2. bag is full and loot.
   3.back to home.

Branch(es):

3.3.5

warn on logout if not max level and not rested

Description:

a lot of newbies logouts on half of no where and because that they loss rested bonus, maybe a warning can be show if they do this.
also with setting where to show:

0 disabled
1 chat
2 screen center
3 both

maybe show distance to nearest innkeeper?

TC rev. hash/commit:

a650bd6

Solo LFG

Description:

Solo LFG if you die you will be kicked out of the instance and the green icon will be gone on the minimap and you will have a Dungeon Finder cooldown.

Current behaviour:

If you leave or have to leave the instance in any way (because you died, for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back into the instance and complete the dungeon.

Expected behaviour:

Solo LFG If you leave or have to leave the instance in any way (because you died for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back to the instance and complete the dungeon and you have a cooldown right away
if you leave the dungeon browser briefly or die then you will not be kicked out of the dungeon browser and will not get a cooldown.

Branch(es):

3.3.5 branch

TC rev. hash/commit:

TrinityCore rev. a8475e5+ 2022-02-01 17:09:28 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)

TDB version:

TDB 335.22011

Operating system: CHANGEME OS

Windows 10

Description:

Solo LFG if you die you will be kicked out of the instance and the green icon will be gone on the minimap and you will have a Dungeon Finder cooldown.

Current behaviour:

If you leave or have to leave the instance in any way (because you died, for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back into the instance and complete the dungeon.

Expected behaviour:

Solo LFG If you leave or have to leave the instance in any way (because you died for example), the dungeon browser ends. You cannot then continue or teleport. So you don't get a reward anymore, even if you go back to the instance and complete the dungeon and you have a cooldown right away
if you leave the dungeon browser briefly or die then you will not be kicked out of the dungeon browser and will not get a cooldown.

Branch(es):

3.3.5 branch

TC rev. hash/commit:

TrinityCore rev. a8475e5+ 2022-02-01 17:09:28 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (worldserver-daemon)

TDB version:

TDB 335.22011

Operating system: CHANGEME OS

Windows 10

add support solo mode in lfg

Description:

lfg system:we must have 5 players to play.

I think we can only one player use lfg system(we can set a npc do that),and press I you need to match queue keep the original function)

Current behaviour:
one player can not use lfg solo

Expected behaviour:

one player can use lfg solo

New Autobalance for TrinityCore

https://github.com/aleigood/TrinityCore-Autobalance

Recreated Solocraft with Flexible Values per map with damage and spell scaling

Description:

Recreated Solocraft with Flexible Values per map with damage and spell scaling.
I have a patch file for the lastest TC 335 ready for travis testing if there is interest in the branch.

Current behavior:

Scales both players health, and damage, and does individual adjustments inspired by my group's Flexcraft V2 module.

Branch(es):

3.3.5

TC rev. hash/commit:

Parent: 1ff4a7e (DB/Quest: Fix CompletionText of 'The Balance of Nature')
Branch: 3.3.5
Follows: TDB335.64

add to passive anticheat one way to notify player accounts of gms to see hacks being used notifications

my idea for easy maintenance is to use a new table on auth database where you fill the player accounts of gms.