tsbyq / openstudio-occupant-variability-gem Goto Github PK

Methods model.getSpaceTypes and space_type.spaces do not return objects in a sorted order. Therefore there is no guarantee that this code will assign the same index to each space if run multiple times:

https://github.com/tsbyq/openstudio-occupant-variability-gem/blob/master/lib/measures/Occupancy_Simulator/measure.rb#L168

I suggest dropping the Space_#{i}_ prefix as space names are already guaranteed to be unique. If you want to keep it, you'll want to sort the spaces and spacetypes by name before looping over them. Also, measure argument names (not the display names) can't have spaces in them due to constraints in OpenStudio server. Suggest using gsub to replace spaces and other characters in space names when creating argument names.

When writing files, measure should write to the current dir ./ rather than the measure resource dir:

https://github.com/tsbyq/openstudio-occupant-variability-gem/blob/master/lib/measures/Occupancy_Simulator/measure.rb#L1079

If multiple instances of the measure are run in parallel they will overwrite each other in the measure resource dir.